Fix docker-compose.yaml.local args - #37
Open
lifeisafractal wants to merge 1 commit into
Open
Conversation
The Dockerfile for app expects TARGETOS and TARGETARCH not GOOS and GOARCH.
Owner
|
hi @lifeisafractal , This values is used by the docker building script, in "docker buildx build" section. |
Contributor
Author
|
@remiheens ah, makes sense. I'm not super familiar with Go, let alone cross compiling it :). Any suggestions for the best way to fix this? I'm happy to implement, test, and open a PR if that helps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Dockerfile for app expects TARGETOS and TARGETARCH not GOOS and GOARCH.
I'm not 100% sure if I'm missing something or not here, bu I needed this modification for things to work. I thought I'd open a PR and we can have a discussion in the comments if I'm off base.