Fix: ensureCleanWorkingDirectory fails with only newly added files in the working directory - #923
Open
terrencekhng wants to merge 4 commits into
Open
Fix: ensureCleanWorkingDirectory fails with only newly added files in the working directory#923terrencekhng wants to merge 4 commits into
terrencekhng wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I think it's a tiny bug. When there are only newly added files in the working directory,
npm run versionis not expected to fail in theensureCleanWorkingDirectorystep.Before:
After:
Change
The trimmed output of
git status --porcelainis an empty string if the working directory is clean for the next version number generation.