refactor(pnpm): rename managerData.pnpmShrinkwrap to pnpmLockFile - #45390
Open
MLuc24 wants to merge 1 commit into
Open
refactor(pnpm): rename managerData.pnpmShrinkwrap to pnpmLockFile#45390MLuc24 wants to merge 1 commit into
MLuc24 wants to merge 1 commit into
Conversation
The field holds the path to pnpm-lock.yaml, and pnpm has not called that file a shrinkwrap since v5, so the old name reads as a different artifact than the one it points at.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Renames
managerData.pnpmShrinkwraptomanagerData.pnpmLockFile, as @viceice asked for in #40780 (review).The field holds the path to
pnpm-lock.yaml. pnpm has not called that file a shrinkwrap since v5, and the neighbouring fields in the same type are already named after the file they point at (yarnLock,packageLock,npmLock), so the old name read as a different artifact than the one it carries.Pure rename, 122 lines across 14 files, no behaviour change. The field is internal to the npm manager —
git grepfinds no reference outsidelib/, and it is not user-facing configuration, so nothing documented changes.Context
managerData.pnpmShrinkwrap#40784AI assistance disclosure
The rename and this description were produced by Claude Opus 5 running in Claude Code. The change is mechanical and was verified by running the suite rather than by inspection.
Use of AI in replying to PR comments
Who answers review comments:
Answering honestly per the template: @MLuc24 owns this account and directs the work, but has not committed to replying to review comments. If a maintainer asks for changes and nobody responds within a reasonable window, please close this rather than leave it open.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
The existing tests and the extract snapshot carry the field name, so they cover the rename directly.
vitest run lib/modules/manager/npm/— 33 files, 522 passedtsc --noEmit -p tsconfig.json— clean, which is what makes a rename of a typed field safegit grep pnpmShrinkwrap— no remaining occurrencesoxlint,biome check,prettier --checkon the changed manager — clean