Skip to content

fix(lint): use parseInt over Number - #45472

Merged
jamietanna merged 3 commits into
mainfrom
fix/number
Aug 26, 2026
Merged

fix(lint): use parseInt over Number#45472
jamietanna merged 3 commits into
mainfrom
fix/number

Conversation

@jamietanna

Copy link
Copy Markdown
Contributor

Changes

As a code review comment that comes up every so often, we can add a
linting rule to enforce this check.

This also fixes any existing usages.

As this could be breaking, we can release it as a fix.

Re-raised #45453 because the Stacked PRs + Merge Queue doesn't seem to like merging the last PR

Context

Please select one of the following:

  • This closes an existing Issue, Closes: #
  • This doesn't close an Issue, but I accept the risk that this PR may be closed if maintainers disagree with its opening or implementation

AI assistance disclosure

Did you use AI tools to create any part of this pull request?

Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.

  • No — I did not use AI for this contribution.
  • Yes — minimal assistance (e.g., IDE autocomplete, small code completions, grammar fixes).
  • Yes — substantive assistance (AI-generated non‑trivial portions of code, tests, or documentation).
  • Yes — other (please describe):

Use of AI in replying to PR comments

Who answers review comments:

  • @jamietanna will read and reply directly. Name the account.
  • An agent will draft replies and @username will read them before they are posted. Name the account.
  • Nobody has explicitly committed to replying.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests, but ran on a real repository, or
  • Both unit tests + ran on a real repository

The public repository:

As a code review comment that comes up every so often, we can add a
linting rule to enforce this check.

This also fixes any existing usages.

As this could be breaking, we can release it as a `fix`.

Co-authored-by: Claude Sonnet 5 <jamie.tanna+claude-code@mend.io>
@jamietanna
jamietanna requested a review from a team August 26, 2026 07:08
@github-actions
github-actions Bot requested a review from viceice August 26, 2026 07:08
Comment thread lib/modules/manager/dockerfile/extract.ts Outdated
Comment thread lib/modules/versioning/pvp/index.ts Outdated
Comment thread lib/util/json-writer/editor-config.ts Outdated
Comment thread lib/modules/versioning/conan/range.ts Outdated
Comment thread lib/modules/versioning/pvp/index.ts Outdated
Comment thread lib/modules/versioning/pvp/index.ts Outdated
@jamietanna
jamietanna requested a review from viceice August 26, 2026 12:42
@jamietanna
jamietanna added this pull request to the merge queue Aug 26, 2026
Merged via the queue into main with commit 0216124 Aug 26, 2026
47 checks passed
@jamietanna
jamietanna deleted the fix/number branch August 26, 2026 13:09
@github-actions

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 44.46.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants