Skip to content

feat(documents): warn incomplete indexing#1511

Open
anouillz wants to merge 1 commit into
rero:stagingfrom
anouillz:goa-files-indexing
Open

feat(documents): warn incomplete indexing#1511
anouillz wants to merge 1 commit into
rero:stagingfrom
anouillz:goa-files-indexing

Conversation

@anouillz

Copy link
Copy Markdown
Contributor

@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

Document API services now query document records for the fulltext_indexing_incomplete metadata flag and expose the result as an observable boolean. Public-search and admin detail views derive reactive indexing-status signals from document PIDs and display warnings in the Get tab when attached-file content is incompletely indexed. Tests add RecordService mocks and verify the public API query and returned status.

Estimated code review effort: 3 (Moderate) | ~20 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: warning about incomplete document indexing.
Description check ✅ Passed The description is directly related to the PR and accurately describes the warning in both document detail views.
Linked Issues check ✅ Passed The changes satisfy #4071 by surfacing the incomplete full-text indexing warning in both public and professional detail views.
Out of Scope Changes check ✅ Passed The added API helpers, UI wiring, and tests are all supporting the requested warning feature and do not appear out of scope.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@anouillz
anouillz force-pushed the goa-files-indexing branch from 80d5333 to e52c2d0 Compare July 14, 2026 09:25
@anouillz

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@projects/public-search/src/app/api/document-api.service.spec.ts`:
- Line 15: Replace Vitest APIs with Jasmine spies: in
projects/public-search/src/app/api/document-api.service.spec.ts at lines 15-15
and 52-52, use jasmine.createSpy('getRecords') and .and.returnValue(...); in
projects/public-search/src/app/document-brief/document-brief.component.spec.ts
at line 39-39, replace vi.fn() with jasmine.createSpy('getRecords').
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4c16741d-4e40-43f9-a6d9-b96ca5e89fb8

📥 Commits

Reviewing files that changed from the base of the PR and between 9e245e9 and e52c2d0.

📒 Files selected for processing (8)
  • projects/admin/src/app/api/document-api.service.ts
  • projects/admin/src/app/record/detail-view/document-detail-view/document-detail-view.component.html
  • projects/admin/src/app/record/detail-view/document-detail-view/document-detail-view.component.ts
  • projects/public-search/src/app/api/document-api.service.spec.ts
  • projects/public-search/src/app/api/document-api.service.ts
  • projects/public-search/src/app/document-brief/document-brief.component.spec.ts
  • projects/public-search/src/app/document-detail/document-detail-view/document-detail-view.component.html
  • projects/public-search/src/app/document-detail/document-detail-view/document-detail-view.component.ts

Comment thread projects/public-search/src/app/api/document-api.service.spec.ts Outdated
Comment thread projects/public-search/src/app/api/document-api.service.ts Outdated
@anouillz
anouillz force-pushed the goa-files-indexing branch 2 times, most recently from 04821c3 to 42c738f Compare July 20, 2026 08:51
@anouillz
anouillz requested a review from Garfield-fr July 20, 2026 09:04
* Displays a warning when some file content is excluded from full-text
  indexing.
* Shows warning in get tab, alongside the files.
* Supports both professional and public document detail views.
* Closes rero/rero-ils#4071

Co-Authored-by: Ana Gomes <anagoncalves7@icloud.com>
@anouillz
anouillz force-pushed the goa-files-indexing branch from 42c738f to 0136245 Compare July 20, 2026 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Files: inform the user when the full-text is too large to be indexed

3 participants