fix(facet-count): count library facets by document

[anouillz]

• Replaces nested facet aggregations with indexed organisation library location paths.
• Stores unique pid combinations in organisation_library_location.
• Uses those paths to count documents instead of holdings.
• Rebuilds the same facet tree for the UI.
• Replaces fix(facet): incorrect counts rero-ils-ui#1508 and fix(facet): incorrect counts ng-core#831.
• Closes The organisation/library facet counts are incorrect #4003

Note: this change adds new indexed fields for document facet counts. Existing records need to be reindexed for the corrected organisation/library/location counts to be available.

[coderabbitai]

Walkthrough

Document indexing now stores document-level organisation, library, and location keyword lists derived from holdings. Facet configuration uses these fields instead of nested holding aggregations. DocumentJSONSerializer reconstructs nested facet buckets, applies view-specific filtering, enriches names, and removes empty buckets. A unit test verifies the resulting hierarchy and counts.

Estimated code review effort: 3 (Moderate) | ~25 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly reflects the main change: fixing facet counts by indexing document-based paths.
Description check	✅ Passed	The description matches the changes: indexed facet paths, document counts, and facet-tree rebuild.
Linked Issues check	✅ Passed	The PR addresses #4003 by fixing library facet counts to reflect documents instead of holdings.
Out of Scope Changes check	✅ Passed	The code changes all support the facet-count fix and add no obvious unrelated functionality.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@rero_ils/modules/documents/serializers/json.py`:
- Around line 201-202: Update the organisation aggregation handling in the
serializer to materialize the doc_count filter as a list and assign that list
back to aggregations["organisation"]["buckets"]. Keep the existing nonzero-count
predicate and subsequent iteration unchanged so global views serialize only
populated organisation buckets.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d598bd13-417d-475a-9d9d-ebcc6be1c1d0

📥 Commits

Reviewing files that changed from the base of the PR and between 2effdad and d26a837.

📒 Files selected for processing (5)

• rero_ils/config.py
• rero_ils/modules/documents/dumpers/indexer.py
• rero_ils/modules/documents/mappings/v7/documents/document-v0.0.1.json
• rero_ils/modules/documents/serializers/json.py
• tests/unit/documents/test_document_organisation_facets.py

[coveralls]

coverage: 91.29% (-0.01%) from 91.303% — anouillz:goa-correct-facet-counts into rero:staging