feat: allow dots in profile names - #133
Merged
Merged
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
cubic analysis
No issues found across 4 files
Linked issue analysis
Linked issue: ENG-4698: Profile names don't support .(dot). Maybe it should
| Status | Acceptance criteria | Notes |
|---|---|---|
| ✅ | Allow '.' in profile names via validation logic | Updated regex to allow dots in validateProfileName |
| ✅ | Update validation error message to mention dots | Error message updated to include 'dots' |
| Update placeholders across all three call sites to preserve dots when generating names | Placeholders updated in two files; third call site not changed | |
| ✅ | Add/modify tests to cover dot-containing profile names and updated messages | Tests added verifying dot names and message content |
| ❌ | Audit or changes to ensure supporting '.' won't break other shell behavior | No audit or other code changes to prevent breakage |
vcapretz
approved these changes
Mar 19, 2026
Profile names can now contain dots, enabling domain-like names such as `resend.com`. Updated validation regex, error message, and placeholder replacements across all three call sites.
felipefreitag
force-pushed
the
worktree-feat-eng-4698-dot-in-profile-names
branch
from
March 19, 2026 19:14
33f7591 to
a457a3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Profile names can now contain dots, enabling domain-like names such as
resend.com. Updated validation regex, error message, and placeholder replacements across all three call sites.