fix: bind to dual-stack address#107
Merged
Merged
Conversation
existing code bound to 0.0.0.0, which works for IP 4&6. in fact :: is technically more correct for dual-stack, but since 0.0.0.0 works for most people most people just use that. IP6-only is rare but becoming less rare, so this will come up more and more. TIL.
pcholakov
approved these changes
Mar 25, 2026
tillrohrmann
approved these changes
Mar 25, 2026
tillrohrmann
left a comment
tillrohrmann
left a comment
Contributor
There was a problem hiding this comment.
LGTM. +1 for merging :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #93
the existing code bound to
0.0.0.0, which works for IP 4&6. in fact::is technically more correct for dual-stack, but since0.0.0.0works for most people most people just use that. IP6-only is rare but becoming less rare, so this will come up more and more. TIL.credit to @miran248 for finding this and suggesting the fix.