Skip to content

integration: Rename to IngegrationSvc#5092

Merged
muhamadazmy merged 1 commit into
mainfrom
pr5092
Jul 22, 2026
Merged

integration: Rename to IngegrationSvc#5092
muhamadazmy merged 1 commit into
mainfrom
pr5092

Conversation

@muhamadazmy

@muhamadazmy muhamadazmy commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Comment thread crates/ingress-http/protobuf/integration_svc.proto Outdated
@chatgpt-codex-connector

Copy link
Copy Markdown

💡 Codex Review


P2 Badge Keep the old gRPC method path or document the break

For clients generated from the previous ingestion_svc.proto, renaming the service changes the canonical gRPC method from /dev.restate.ingress.ingestion.IngestionSvc/Ingest to /dev.restate.ingress.integration.IntegrationSvc/Ingest; those clients fail before the version-negotiation headers can be exchanged. If this protocol has been consumed outside this branch, this needs either a compatibility alias for the old service path or an explicit breaking-change/release note instead of a silent rename.

AGENTS.md reference: AGENTS.md:L51-L51

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@slinkydeveloper slinkydeveloper left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i love it, let's go!

@muhamadazmy
muhamadazmy merged commit baaf5ad into main Jul 22, 2026
18 checks passed
@muhamadazmy
muhamadazmy deleted the pr5092 branch July 22, 2026 12:59
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants