chore: auto-install cargo-nextest in just test#113
Closed
OmarAshour02 wants to merge 1 commit into
Closed
Conversation
`just verify` calls `cargo nextest run` but the justfile did not install cargo-nextest, so new contributors hit `error: no such command: nextest`. Mirror the existing `_target-installed` pattern by adding a `_nextest-installed` recipe that installs cargo-nextest if missing, falling back to 0.9.128 when the latest release's MSRV exceeds the toolchain pinned in `rust-toolchain.toml`.
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
|
i think this is not needed, i dont' like a tool that goes and autoinstalls something like this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
just verifycallscargo nextest run, but the justfile didn't installcargo-nextest, so new contributors hiterror: no such command: nexteston their first run._nextest-installedrecipe (mirroring the existing_target-installedpattern) that installscargo-nextestif missing.cargo-nextest 0.9.128when the latest release's MSRV exceeds the toolchain pinned inrust-toolchain.toml(currently 1.90.0; latest nextest needs 1.91+).Test plan
cargo-nextestinstalled:just verifytriggers installcargo-nextestalready installed:just verifyis a no-op for the install step0.9.128kicks in