Open
Conversation
…) to CloudKMS Handles re-create after delete by detecting missing enabled versions and creating a new key version instead of failing on existing keyring/key.
Restore and re-enable the primary key version instead of creating a new one, avoiding unnecessary version proliferation after delete/re-create.
ErraticO
force-pushed
the
feature/add-more-methods
branch
from
17d6684 to
f5bc18b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds full GCP infrastructure teardown support via a new
--deleteCLI command, and improves VM image baking performance through parallelization.Changes
--deleteCLI command (gcp_cli.py,infra.py)--deleteflag to the GCP infra CLI to tear down all provisioned resourcesdelete()orchestration ininfra.pycovering the full resource lifecycleResource-level
delete()methods (artifacts.py,iam.py,pre_vm_image.py)delete()toArtifacts,IAM, andPreVMImageclasses to support granular teardownCloudKMS delete & re-create handling (
kms.py)delete(),describe_enabled_key_version(), andcreate_key_version()toCloudKMScreate_key_versionwithenable_primary_key_versionto restore and re-enable the existing primary key version, avoiding unnecessary version proliferationParallelized VM image baking (
infra.py,pre_vm_image.py)