Instantly run task after write operation#1460
Merged
booky10 merged 8 commits intoretrooper:2.0from Apr 7, 2026
Merged
Conversation
This was used previously while we still relied on netty's built-in MessageToMessageEncoder, which didn't allow to have proper "tasks-after-send"
We really need to refactor these copy-pasted handlers into a common module...
Why does this list of runnables only exist for clientbound packets? Doesn't make sense to me
booky10
approved these changes
Apr 7, 2026
Collaborator
There was a problem hiding this comment.
Thanks for the fix, I also applied your changes to sponge and fabric
This promise-based handling is because our spigot/paper outbound handler used to be a MessageToMessageEncoder and never was removed when we stopped using that
Sorry for the long wait!
Owner
|
Thank you for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now it's possible other packets get written before the promise is completed, If you want to write a packet right after another packet using getTasksAfterSend it's possible another packet gets written inbetween. This solves it for spigot (sponge needs a different type of implementation, probably overwriting the whole write function to execute the tasks).