Skip to content

chore: update deny config to allow-list unmaintained test crate#1192

Merged
reubeno merged 1 commit into
mainfrom
deny-errors
Jun 9, 2026
Merged

chore: update deny config to allow-list unmaintained test crate#1192
reubeno merged 1 commit into
mainfrom
deny-errors

Conversation

@reubeno

@reubeno reubeno commented Jun 9, 2026

Copy link
Copy Markdown
Owner

No description provided.

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

Test Results

    5 files     40 suites   15m 7s ⏱️
2 488 tests 2 488 ✅ 0 💤 0 ❌
7 733 runs  7 733 ✅ 0 💤 0 ❌

Results for commit bb292b8.

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

Performance Benchmark Report

Benchmark name Baseline (μs) Test/PR (μs) Delta (μs) Delta %
clone_shell_object 17.52 μs 17.47 μs -0.05 μs ⚪ Unchanged
eval_arithmetic 0.15 μs 0.15 μs 0.00 μs ⚪ Unchanged
expand_one_string 1.63 μs 1.67 μs 0.04 μs ⚪ Unchanged
for_loop 31.03 μs 31.39 μs 0.36 μs ⚪ Unchanged
full_peg_complex 56.05 μs 56.16 μs 0.11 μs ⚪ Unchanged
full_peg_for_loop 6.21 μs 6.24 μs 0.03 μs ⚪ Unchanged
full_peg_nested_expansions 16.55 μs 16.61 μs 0.05 μs ⚪ Unchanged
full_peg_pipeline 4.17 μs 4.26 μs 0.09 μs 🟠 +2.08%
full_peg_simple 1.74 μs 1.76 μs 0.02 μs ⚪ Unchanged
function_call 3.44 μs 3.44 μs 0.00 μs ⚪ Unchanged
instantiate_shell 55.03 μs 55.85 μs 0.82 μs ⚪ Unchanged
instantiate_shell_with_init_scripts 27401.45 μs 27622.95 μs 221.50 μs ⚪ Unchanged
parse_peg_bash_completion 2080.53 μs 2094.69 μs 14.16 μs ⚪ Unchanged
parse_peg_complex 18.74 μs 18.75 μs 0.01 μs ⚪ Unchanged
parse_peg_for_loop 1.84 μs 1.87 μs 0.03 μs 🟠 +1.58%
parse_peg_pipeline 2.03 μs 1.92 μs -0.11 μs ⚪ Unchanged
parse_peg_simple 1.02 μs 1.04 μs 0.01 μs ⚪ Unchanged
run_echo_builtin_command 15.63 μs 15.51 μs -0.12 μs ⚪ Unchanged
tokenize_sample_script 3.52 μs 3.56 μs 0.04 μs ⚪ Unchanged

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
brush-core\src\openfiles.rs 🔴 10.5% 🔴 10.94% 🟢 0.44%
brush-core\src\shell\fs.rs 🔴 13.04% 🔴 12.1% 🔴 -0.94%
Overall Coverage 🟢 25.82% 🟢 25.83% 🟢 0.01%

Minimum allowed coverage is 20%, this run produced 25.83%
Maximum allowed coverage difference is -5%, this run produced 0.01%

Test Summary: bash-completion test suite

Outcome Count Percentage
✅ Pass 1582 75.01
❗️ Error 18 0.85
❌ Fail 155 7.35
⏩ Skip 339 16.07
❎ Expected Fail 13 0.62
✔️ Unexpected Pass 2 0.09
📊 Total 2109 100.00

@reubeno
reubeno marked this pull request as ready for review June 9, 2026 06:55
@reubeno
reubeno requested a review from Copilot June 9, 2026 06:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the workspace cargo-deny configuration to silence a new RustSec advisory for a test-only dependency, keeping advisory checks actionable while upstream work to replace the crate is pending.

Changes:

  • Replaces the ignored RustSec advisory entry in deny.toml with RUSTSEC-2026-0173 for proc-macro-error2.
  • Documents that the ignored advisory is for a test-only dependency chain (test-with) and is intended to be temporary.

@reubeno
reubeno merged commit c9dba3b into main Jun 9, 2026
48 of 49 checks passed
@reubeno
reubeno deleted the deny-errors branch June 9, 2026 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants