kill: implement an option for trigger kernel oom killer - #362
Closed
IceLocke wants to merge 5 commits into
Closed
Conversation
|
@rfjakob PTAL |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
rfjakob
reviewed
Feb 10, 2026
Comment on lines
+416
to
+418
| // If running as root, should have permission and return 0 | ||
| // If not root, should return -1 (permission denied) | ||
| if os.Getuid() == 0 { |
Owner
There was a problem hiding this comment.
This check does not work in a container (and in github actions).
I suggest you do syscall.Access() from Go and check that the trigger_kernel_oom_killer() result matches what we expect acc. to the syscall.Acecss() result
Contributor
Author
There was a problem hiding this comment.
Done. I have swithed to syscall.Access() and checked the result in CI
rfjakob
requested changes
Feb 10, 2026
rfjakob
left a comment
rfjakob
left a comment
Owner
There was a problem hiding this comment.
Small problem with the tests, otherwise nice
Owner
|
Merged as 31707b9, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in issue #358 and README, after Linux 5.17, OOM sysrq will always kill a process.
This implements an option for trigger the kernel oom killer i.e. write an
fto/proc/sysrq-trigger. Since the victim cannot be chosen by earlyoom, some of the features about customized victim selection won't take effect.