-
Notifications
You must be signed in to change notification settings - Fork 37
feat: turn off screens when idle #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fspy
wants to merge
1
commit into
rharish101:main
Choose a base branch
from
fspy:feature/idle
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -336,6 +336,19 @@ impl AsyncComponent for Greeter { | |
| let mut model = Self::new(&input.config_path, input.demo).await; | ||
| let widgets = view_output!(); | ||
|
|
||
| // Start idle monitoring in a separate thread if configured | ||
| if let Some(timeout_seconds) = model.config.get_idle_timeout() { | ||
| if timeout_seconds > 0 { | ||
| let timeout_ms = (timeout_seconds * 1000) as u32; | ||
| std::thread::spawn(move || { | ||
| if let Err(e) = crate::idle::run_idle_loop(timeout_ms) { | ||
| tracing::error!("Idle monitoring failed: {}", e); | ||
| } | ||
| }); | ||
|
Comment on lines
+343
to
+347
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please use |
||
| tracing::info!("Started idle monitoring with {}s timeout", timeout_seconds); | ||
| } | ||
| } | ||
|
|
||
| // Make the info bar permanently visible, since it was made invisible during init. The | ||
| // actual visuals are controlled by `InfoBar::set_revealed`. | ||
| widgets.ui.error_info.set_visible(true); | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit of bikeshedding - I think that the top-level key should just be called
[idle]. But it's not that important.The thing that bothers me more is the unspecific
timeout_durationkey.I think it would be nice for the greeter to optionally suspend the system if it is idle. It doesn't need to be done in this PR, but I think such a feature will be added eventually. Thus, the key that turns the screens off should be more specific to avoid confusion in the future. For user's convenience, I don't see any issues with aliasing it in serde it to allow "screen", "monitor", and "display" timeouts.
Additionally, it would be nice to use
humantime-serdebecause ffs if I have to convert from minutes, or hours to seconds once again, I will go insane.