Skip to content

Add config option to skip selecting user/session#81

Open
rharish101 wants to merge 3 commits intomainfrom
skip_selection
Open

Add config option to skip selecting user/session#81
rharish101 wants to merge 3 commits intomainfrom
skip_selection

Conversation

@rharish101
Copy link
Copy Markdown
Owner

@rharish101 rharish101 commented Aug 4, 2024

Resolves #57 and resolves #33.

- Resolves #33.
- The ReGreet cache is more of a state, especially with the skipping
  selection option.
- NOTE: This does break backwards-compat.
@rharish101 rharish101 mentioned this pull request Aug 13, 2024
@lyghtnox
Copy link
Copy Markdown

lyghtnox commented Jan 2, 2025

Hey,
I've tried his PR after merging it to main locally and everything works as expected using Hyprland as a compositor.
Any plan to merge and release this PR ?

@rharish101
Copy link
Copy Markdown
Owner Author

rharish101 commented Jan 2, 2025

Unfortunately, this is blocked on me figuring out a way to handle the case when the user doesn't have a password set. Right now, the user is automatically logged into their last session, and there would be no way for them to change their session (unless they change the config to disable this feature). You can check the discussion on the issue page: #57.

@Norlock
Copy link
Copy Markdown

Norlock commented Jan 10, 2025

Just a question but why would a user not have a password set?

@Norlock
Copy link
Copy Markdown

Norlock commented Jan 10, 2025

Have you thought about letting this set the user in the config.toml? Something like ask_password = false .

@rharish101
Copy link
Copy Markdown
Owner Author

Just a question but why would a user not have a password set?

Who knows why? It's part of the spec, so I have to handle it.

Have you thought about letting this set the user in the config.toml? Something like ask_password = false .

I'm not sure what you mean by this.

@Norlock
Copy link
Copy Markdown

Norlock commented Jan 12, 2025

I mean the PR already kind of does this, let the user set it in config or remember after first login if you want to show the password field immediately or not. You don't need to derive it from some command or something where you need extra privileges

@allmeta
Copy link
Copy Markdown

allmeta commented Feb 26, 2025

Bump

@Fractal-Tess
Copy link
Copy Markdown

I would like to see this merged in

@Furyfree
Copy link
Copy Markdown

Furyfree commented Jan 6, 2026

Hi! I’ve started using ReGreet and came across this PR. Is this still something you’re planning to merge, or has it stalled? I was considering implementing something similar myself, but noticed this already exists, so I wanted to check before duplicating work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skip selecting session Should /var/cache/regreet/cache.toml be moved to /var/lib/regreet/state.toml?

6 participants