Don't emit ENCRYPTION_WARNING for x84_64 in TUI#42
Open
prudo1 wants to merge 1 commit into
Open
Conversation
With x86 now supporting encrypted dump target commit a6c2cf4 ("Don't emit ENCRYPTION_WARNING for x86_64") removed printing the warning for x86. However it only did it for the GUI not the TUI. Suppress the warning there as well. Fixes: a6c2cf4 ("Don't emit ENCRYPTION_WARNING for x86_64") Signed-off-by: Philipp Rudo <prudo@redhat.com>
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider reusing the same architecture-checking helper or logic used by the GUI path so that the condition for suppressing ENCRYPTION_WARNING is defined in a single place rather than duplicating the arch string comparison here.
- If possible, avoid hardcoding the string "x86_64" directly in the TUI code and instead reference a shared constant or helper to reduce the chance of subtle mismatches with other architecture checks.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider reusing the same architecture-checking helper or logic used by the GUI path so that the condition for suppressing ENCRYPTION_WARNING is defined in a single place rather than duplicating the arch string comparison here.
- If possible, avoid hardcoding the string "x86_64" directly in the TUI code and instead reference a shared constant or helper to reduce the chance of subtle mismatches with other architecture checks.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Code Review
This pull request updates the kdump TUI spoke to suppress encryption warnings on the x86_64 architecture by modifying the refresh method. A review comment identifies a consistency issue where the status property still returns a warning regardless of architecture, which would cause the main hub to display a warning that disappears upon entering the spoke; it is recommended to apply the architecture check to the status property as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With x86 now supporting encrypted dump target commit a6c2cf4 ("Don't emit ENCRYPTION_WARNING for x86_64") removed printing the warning for x86. However it only did it for the GUI not the TUI. Suppress the warning there as well.
Fixes: a6c2cf4 ("Don't emit ENCRYPTION_WARNING for x86_64")