Skip to content

Don't emit ENCRYPTION_WARNING for x84_64 in TUI#42

Open
prudo1 wants to merge 1 commit into
rhinstaller:mainfrom
prudo1:fixes/ENCRYPTION_WARNING
Open

Don't emit ENCRYPTION_WARNING for x84_64 in TUI#42
prudo1 wants to merge 1 commit into
rhinstaller:mainfrom
prudo1:fixes/ENCRYPTION_WARNING

Conversation

@prudo1

@prudo1 prudo1 commented May 4, 2026

Copy link
Copy Markdown

With x86 now supporting encrypted dump target commit a6c2cf4 ("Don't emit ENCRYPTION_WARNING for x86_64") removed printing the warning for x86. However it only did it for the GUI not the TUI. Suppress the warning there as well.

Fixes: a6c2cf4 ("Don't emit ENCRYPTION_WARNING for x86_64")

With x86 now supporting encrypted dump target commit a6c2cf4 ("Don't
emit ENCRYPTION_WARNING for x86_64") removed printing the warning for
x86. However it only did it for the GUI not the TUI. Suppress the
warning there as well.

Fixes: a6c2cf4 ("Don't emit ENCRYPTION_WARNING for x86_64")
Signed-off-by: Philipp Rudo <prudo@redhat.com>

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider reusing the same architecture-checking helper or logic used by the GUI path so that the condition for suppressing ENCRYPTION_WARNING is defined in a single place rather than duplicating the arch string comparison here.
  • If possible, avoid hardcoding the string "x86_64" directly in the TUI code and instead reference a shared constant or helper to reduce the chance of subtle mismatches with other architecture checks.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider reusing the same architecture-checking helper or logic used by the GUI path so that the condition for suppressing ENCRYPTION_WARNING is defined in a single place rather than duplicating the arch string comparison here.
- If possible, avoid hardcoding the string "x86_64" directly in the TUI code and instead reference a shared constant or helper to reduce the chance of subtle mismatches with other architecture checks.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the kdump TUI spoke to suppress encryption warnings on the x86_64 architecture by modifying the refresh method. A review comment identifies a consistency issue where the status property still returns a warning regardless of architecture, which would cause the main hub to display a warning that disappears upon entering the spoke; it is recommended to apply the architecture check to the status property as well.

Comment thread com_redhat_kdump/tui/spokes/kdump.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant