Add title attribute to block-preview elements for displaying element name#286
Open
timoschraa wants to merge 4 commits intorickbutterfield:v5/devfrom
Open
Add title attribute to block-preview elements for displaying element name#286timoschraa wants to merge 4 commits intorickbutterfield:v5/devfrom
timoschraa wants to merge 4 commits intorickbutterfield:v5/devfrom
Conversation
added 2 commits
April 2, 2026 12:20
…ttribute which will display on hover
timoschraa
changed the title
Owner
|
Hey @timoschraa! This a great straightforward fix, thank you! Please can you merge in the latest changes from v5/dev and resolve the conflict. I'll get it merged in after that. |
added 2 commits
April 11, 2026 19:12
…ent-description # Conflicts: # src/Umbraco.Community.BlockPreview.UI/src/blockEditor/block-preview-base.element.ts
Author
|
@rickbutterfield done ✅ Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add title attribute to block-preview elements so inside the block preview elements you know which element you are editing/opening. This could be a specific case for us, but I think it could be useful for more companies that use the BlockPreview. Like this you have more control/context about which element will be edited.
Would appreciate the merge, let me know if you have any questions regarding the change :)