Skip to content

cleanup & test fix#14

Open
ThunderEX wants to merge 4 commits into
ricmoo:masterfrom
ThunderEX:master
Open

cleanup & test fix#14
ThunderEX wants to merge 4 commits into
ricmoo:masterfrom
ThunderEX:master

Conversation

@ThunderEX

Copy link
Copy Markdown

This PR include:

  1. remove dependency on copy module which is unnecessary, that also allow pyaes run on micropython.
  2. fix imports. for tests, correct path of import, use recommended absolute import to replace relative import, rename StringIO to BytesIO to fit real variable type.
  3. remove ugly workaround for py2/3, replace with bytes/bytearray.
  4. don't mask MSB, increase speed a little bit

@ricmoo

ricmoo commented May 4, 2017

Copy link
Copy Markdown
Owner

Awesome work! Thank you.

I haven't dealt much with Python 3, but will research these changes next week and verify the test cases, and if all is good merge. :)

@ThunderEX

Copy link
Copy Markdown
Author

@ricmoo I mistakenly break down python2 in last commit and now fix it up. pls have a look~

@ricmoo

ricmoo commented May 17, 2017

Copy link
Copy Markdown
Owner

Thanks! I'll look at this next week, as this week is pretty busy. I have a lot of house cleaning to catch up on for my various GitHub projects...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants