refactor(data): centralize site content - #19
Merged
Conversation
georg-schwarz
force-pushed
the
separate-content-from-page
branch
from
March 3, 2026 17:00
7c77280 to
6dcd004
Compare
Keep brand types in data-models and localize page title formatting to the layout with updated docs.
There was a problem hiding this comment.
Pull request overview
Refactors the Astro site to centralize site copy/config under src/data/ and move shared type definitions into src/data-models/, updating pages/components/docs to consume these new modules.
Changes:
- Moved brand config imports from
@/config/brandto@/data/brandacross layouts/pages. - Centralized page-level strings/labels into new
src/data/*modules (home/about/blog/resources). - Introduced
src/data-models/*for shared TypeScript types and updated consumers accordingly.
Reviewed changes
Copilot reviewed 21 out of 22 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/pages/rss.xml.ts | Updates brand config import to new src/data/brand location. |
| src/pages/resources/index.astro | Replaces inline copy with RESOURCES_PAGE_CONTENT. |
| src/pages/resources/[...slug].astro | Uses centralized resource labels (updated/canonical/related). |
| src/pages/index.astro | Uses HOME_PAGE_CONTENT for hero/section/CTA copy. |
| src/pages/blog/index.astro | Uses BLOG_PAGE_CONTENT for title/empty state. |
| src/pages/about.astro | Uses ABOUT_PAGE_CONTENT and AboutSection model for section rendering. |
| src/layouts/BaseLayout.astro | Updates brand config import path. |
| src/data/resources.ts | Adds centralized resources page copy object. |
| src/data/home.ts | Moves Feature type to data-models and adds HOME_PAGE_CONTENT. |
| src/data/brand.ts | Updates SocialPlatform type import to data-models. |
| src/data/blog.ts | Adds centralized blog page copy object. |
| src/data/about.ts | Moves types to data-models and adds ABOUT_PAGE_CONTENT. |
| src/data-models/social.ts | Introduces SocialPlatform union type. |
| src/data-models/resources.ts | Introduces ResourcesPageContent interface. |
| src/data-models/home.ts | Introduces Feature and HomePageContent interfaces. |
| src/data-models/blog.ts | Introduces BlogPageContent interface. |
| src/data-models/about.ts | Introduces About page content + team member models. |
| src/components/features/Team.astro | Switches to shared TeamMember model import. |
| src/components/features/SocialLinks.astro | Switches to shared SocialPlatform model import. |
| README.md | Updates branding path + documents new site content pattern. |
| AGENTS.md | Updates branding path + documents new site content pattern. |
Comments suppressed due to low confidence (1)
src/components/features/Team.astro:6
TEAM_MEMBERSis typed as areadonly TeamMember[](viasatisfies readonly TeamMember[]insrc/data/about.ts), but this component's prop expects a mutableTeamMember[]. In strict TS this makes<Team members={TEAM_MEMBERS} />fail type-checking. Consider changing the prop tomembers: readonly TeamMember[]to accept both readonly and mutable arrays (matching the pattern used bySocialLinks).
export interface Props {
members: TeamMember[];
title?: string;
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Make TeamMember.bio optional to match conditional rendering in Team component.
Waldleufer
approved these changes
Mar 4, 2026
Waldleufer
left a comment
Collaborator
There was a problem hiding this comment.
I like the separation of concerns 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/data-modelsto separate from actual datasrc/dataso we have most configuration in thedatafolderdatamodules