feat!: use QCS core-deps; update OTEL version#35
Merged
Conversation
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
BatmanAoD
force-pushed
the
feat-use-core-deps-update-otel-version
branch
3 times, most recently
from
98b4fbb to
ded54a8
Compare
Shadow53
reviewed
May 22, 2026
BatmanAoD
force-pushed
the
feat-use-core-deps-update-otel-version
branch
from
090e604 to
d9d2922
Compare
BatmanAoD
force-pushed
the
feat-use-core-deps-update-otel-version
branch
3 times, most recently
from
225ceed to
7c878d8
Compare
BatmanAoD
commented
May 24, 2026
| description = "Macro for passing OpenTelemetry context from Python to Rust" | ||
| repository = "https://github.com/rigetti/pyo3-opentelemetry" | ||
| rust-version = "1.83.0" | ||
| rust-version = "1.88.0" |
Contributor
Author
There was a problem hiding this comment.
required by tonic 0.14
BatmanAoD
commented
May 24, 2026
| //! This module provides a function to evaluate Python stub file templates for the Python module | ||
| //! added by `pyo3_tracing_subscriber::add_submodule`. Upstream build scripts may use this to write | ||
| //! the Python stub files in their build scripts. | ||
| //! This crate provides a function to generate Python stub files for the Python module added by |
Contributor
Author
There was a problem hiding this comment.
Moving this to its own crate was necessitated by the removal of the pyo3 feature (which seemed silly and confusing to me for a set of crates with "pyo3" in their names), because use of PyO3 crates necessitate linking against libpython for standalone binaries but cannot link against libpython when building an extension module. Since a build script is a binary, any dependency on a pyo3 library caused the build to fail when built as an extension module.
BatmanAoD
force-pushed
the
feat-use-core-deps-update-otel-version
branch
from
7c878d8 to
6326ebe
Compare
BatmanAoD
commented
May 24, 2026
| //! # Related Crates | ||
| //! | ||
| //! * `pyo3-opentelemetry` - propagates `OpenTelemetry` contexts from Python into Rust. | ||
| #[cfg(feature = "pyo3")] |
Contributor
Author
There was a problem hiding this comment.
This is why I removed the pyo3 feature: every single item in this crate is dependent on that feature. So the crate is simply empty without the pyo3 feature enabled.
BatmanAoD
changed the title
BatmanAoD
force-pushed
the
feat-use-core-deps-update-otel-version
branch
2 times, most recently
from
42e27b0 to
9c3f0d9
Compare
…o3 dependency, so extract it to separate crate, like prost-build
BatmanAoD
force-pushed
the
feat-use-core-deps-update-otel-version
branch
2 times, most recently
from
a5815f8 to
9c99297
Compare
BatmanAoD
force-pushed
the
feat-use-core-deps-update-otel-version
branch
3 times, most recently
from
8adc1a7 to
14fd7f2
Compare
jselig-rigetti
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change because [a] updating OTEL is always a breaking change and [b] I removed the
pyo3feature (since it always needs to be enabled for the crates to be useful) and, because of that, had to move stubs generation into a new crate.