fix: align the layout tab template order with the other grids#116
Merged
Conversation
Signed-off-by: Rizki Citra <rimzzlabs@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three surfaces render a template grid: the browse page, the create dialog, and the editor's Layout tab. The earlier alignment fix (#107) sorted the create dialog to match the browse page's default order but did it with a local copy of the sort, and the Layout tab was missed entirely; it still rendered the catalog's declaration order (Awal, Ketat, Luasa, Tebal, Klasik, Ketik).
The ordering now lives once in the catalog:
SORTED_TEMPLATESinsrc/lib/templates.ts, pre-sorted by the default browse sort. The Layout tab and the create dialog both render it, and the dialog's local sorting is gone. The browse page keeps its user-controlled sort toolbar, whose default already produces the same list, so a fourth surface added tomorrow has one obvious import to reach for.Testing: read the rendered tile names in order from all three surfaces and confirmed they match exactly (Awal, Ketat, Ketik, Klasik, Luasa, Tebal); the browse page's sort toolbar still re-sorts on demand.