Clarify the word "canonical" in "canonical NaN"#2867
Clarify the word "canonical" in "canonical NaN"#2867dramforever wants to merge 1 commit intoriscv:mainfrom
Conversation
Normative Rule Changes DetectedThis PR modifies normatively tagged text. Please review the changes below to ensure they are intentional. View Detected ChangesNormative Tag Change Reportriscv-spec SpecificationWhat happens next:
How to update reference files (if needed): make update-ref
git add ref/*.json
git commit -m "Update normative tag reference files"
This comment was automatically generated by the normative tag check workflow. |
aswaterman
left a comment
There was a problem hiding this comment.
Funny, even the Wikipedia article on NaN includes this caveat.
|
@dramforever you need to sign your commit with your RSA key as described in https://github.com/riscv/riscv-isa-manual/blob/275f9c941ba4ee71f66cc338ad75e78e68f51a41/CONTRIBUTING.md#signing-github.qkg1.topmits--step-by-step then amend the commit and force-push over the branch. |
We define a "canonical NaN" for each format, which is unrelated to the concept of canonical encodings in IEEE 754. The latter only makes sense for decimal encodings anyway. Add a non-normative note clarifying this. IEEE 754-2019 adds a clarifying note that "In binary interchange formats, all number and NaN encodings are canonical." However, I think it's more confusing to explain it this way in the context of this note, so I didn't mention it. Signed-off-by: Vivian Wang <wangruikang@iscas.ac.cn>
71a2745 to
aa7ad7d
Compare
|
Oops, missed that signing requirement. Should be signed now. |
|
@dramforever No problem; it is a recent requirement. |
We define a "canonical NaN" for each format, which is unrelated to the concept of canonical encodings in IEEE 754. The latter only makes sense for decimal encodings anyway. Add a non-normative note clarifying this.
IEEE 754-2019 adds a clarifying note that "In binary interchange formats, all number and NaN encodings are canonical." However, I think it's more confusing to explain it this way in the context of this note, so I didn't mention it.
cc @Icenowy
See also a similar clarification for WebAssembly: WebAssembly/spec#1614