Clarify which Smdbltrp SRET behaviors are qualified by M-mode#2871
Open
aswaterman wants to merge 1 commit intomainfrom
Open
Clarify which Smdbltrp SRET behaviors are qualified by M-mode#2871aswaterman wants to merge 1 commit intomainfrom
aswaterman wants to merge 1 commit intomainfrom
Conversation
Member
Author
Normative Rule Changes DetectedThis PR modifies normatively tagged text. Please review the changes below to ensure they are intentional. View Detected ChangesNormative Tag Change Reportriscv-spec SpecificationWhat happens next:
How to update reference files (if needed): make update-ref
git add ref/*.json
git commit -m "Update normative tag reference files"
This comment was automatically generated by the normative tag check workflow. |
Collaborator
|
LGTM. Left three suggestions. |
ved-rivos
reviewed
Apr 12, 2026
| an `SRET` instruction while the current privilege mode is M, has the following additional | ||
| effects. | ||
| [#norm:mstatus_mdt_clr_mret_sret]#The `MDT` bit is set to 0.# | ||
| [#norm:sstatus_sdt_clr_mret_sret]#If the new privilege mode is U, VS, or VU, then `sstatus.SDT` is also set to 0.# |
Collaborator
There was a problem hiding this comment.
Suggested change
| [#norm:sstatus_sdt_clr_mret_sret]#If the new privilege mode is U, VS, or VU, then `sstatus.SDT` is also set to 0.# | |
| [#norm:sstatus_sdt_clr_mret_sret]#If the Ssdbltrp extension is also implemented, and the new privilege mode is U, VS, or VU, then `sstatus.SDT` is also set to 0.# |
ved-rivos
approved these changes
Apr 12, 2026
ved-rivos
approved these changes
Apr 12, 2026
| [#norm:sstatus_sdt_clr_mret_sret]#If the new privilege mode is U, VS, or VU, then `sstatus.SDT` is also set to 0.# | ||
| [#norm:vsstatus_sdt_clr_mret_sret]#Additionally, if it is VU, then `vsstatus.SDT` is also set to 0.# | ||
|
|
||
| [#norm:mstatus_mdt_clr_mnret]#The `MNRET` instruction, provided by the Smrnmi extension, sets the `MDT` bit to 0 if the new privilege mode is not M.# |
Collaborator
There was a problem hiding this comment.
Suggested change
| [#norm:mstatus_mdt_clr_mnret]#When the Smdbltrp extension is implemented, the `MNRET` instruction, provided by the Smrnmi extension, sets the `MDT` bit to 0 if the new privilege mode is not M.# |
| [#norm:vsstatus_sdt_clr_mret_sret]#Additionally, if it is VU, then `vsstatus.SDT` is also set to 0.# | ||
|
|
||
| [#norm:mstatus_mdt_clr_mnret]#The `MNRET` instruction, provided by the Smrnmi extension, sets the `MDT` bit to 0 if the new privilege mode is not M.# | ||
| [#norm:sstatus_sdt_clr_mnret]#If it is U, VS, or VU, then `sstatus.SDT` is also set to 0.# |
Collaborator
There was a problem hiding this comment.
Suggested change
| [#norm:sstatus_sdt_clr_mnret]#If the Ssdbltrp extension is also implemented, and the new privilege mode is U, VS, or VU, then `sstatus.SDT` is also set to 0.# |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #2870