feat: add asset code filter for campaign discovery - #44
Merged
Conversation
|
@Escelit is attempting to deploy a commit to the ritik4ever's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Escelit Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Owner
|
@Escelit please resolve the conflicts |
Contributor
Author
|
@ritik4ever merge conflicts has been successfully resolved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a client-side asset filter dropdown to the campaign board. No new API endpoints or data models needed.
Changes
campaignsTableUtils.ts — two pure utility functions: getDistinctAssetCodes (deduplicates and sorts asset codes from campaign data) and applyFilters (applies asset + status predicates simultaneously)
AssetFilterDropdown.tsx — new controlled component, defaults to "All assets", disabled when no campaigns are loaded CampaignsTable.tsx — wired up filter state, derived options, combined filtering logic, and empty-state messaging CreateCampaignForm.tsx — fixed missing useEffect import (pre-existing bug) Closes #2