Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
116 changes: 116 additions & 0 deletions frontend/src/components/CampaignsTable.debounce.test.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,116 @@
/**
* Integration tests verifying that CampaignsTable debounces the onSearchChange
* callback and fires immediately on clear (#254).
*/
import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
import { render, screen, act, fireEvent } from '@testing-library/react';
import { MemoryRouter } from 'react-router-dom';
import { CampaignsTable } from './CampaignsTable';
import type { Campaign } from '../types/campaign';

// jsdom does not implement matchMedia
Object.defineProperty(window, 'matchMedia', {
writable: true,
value: vi.fn().mockImplementation((query: string) => ({
matches: false,
media: query,
onchange: null,
addListener: vi.fn(),
removeListener: vi.fn(),
addEventListener: vi.fn(),
removeEventListener: vi.fn(),
dispatchEvent: vi.fn(),
})),
});

const STUB_CAMPAIGN: Campaign = {
id: 'c1',
creator: 'G' + 'A'.repeat(55),
title: 'Test Campaign',
description: 'desc',
acceptedTokens: ['XLM'],
assetCode: 'XLM',
targetAmount: 1000,
pledgedAmount: 0,
deadline: Date.now() / 1000 + 86400,
createdAt: Date.now() / 1000,
progress: { percentage: 0, pledgedAmount: 0, targetAmount: 1000 },
};

function renderTable(onSearchChange: (q: string) => void) {
return render(
<MemoryRouter>
<CampaignsTable
campaigns={[STUB_CAMPAIGN]}
selectedCampaignId={null}
onSelect={vi.fn()}
isLoading={false}
hasMore={false}
onSearchChange={onSearchChange}
/>
</MemoryRouter>,
);
}

describe('CampaignsTable debounced search (#254)', () => {
beforeEach(() => {
vi.useFakeTimers();
});

afterEach(() => {
vi.runOnlyPendingTimers();
vi.useRealTimers();
});

it('does not call onSearchChange before 300 ms elapses', () => {
const onSearchChange = vi.fn();
renderTable(onSearchChange);

const input = screen.getByRole('textbox', { name: /search campaigns/i });
fireEvent.change(input, { target: { value: 'ro' } });

// Timer not advanced — debounce window not expired
const nonEmptyCalls = onSearchChange.mock.calls.filter(([v]) => v !== '');
expect(nonEmptyCalls).toHaveLength(0);
});

it('calls onSearchChange exactly once after 300 ms pause', async () => {
const onSearchChange = vi.fn();
renderTable(onSearchChange);

const input = screen.getByRole('textbox', { name: /search campaigns/i });
fireEvent.change(input, { target: { value: 'r' } });
fireEvent.change(input, { target: { value: 'ro' } });
fireEvent.change(input, { target: { value: 'roc' } });
fireEvent.change(input, { target: { value: 'rock' } });

// No callback yet
expect(onSearchChange).not.toHaveBeenCalledWith('rock');

// Advance past the debounce delay
await act(async () => { vi.advanceTimersByTime(300); });

const rocketCalls = onSearchChange.mock.calls.filter(([v]) => v === 'rock');
expect(rocketCalls).toHaveLength(1);
// Not called for each intermediate keystroke
const allNonEmpty = onSearchChange.mock.calls.filter(([v]) => v !== '');
expect(allNonEmpty.length).toBeLessThanOrEqual(1);
});

it('fires onSearchChange immediately when input is cleared', async () => {
const onSearchChange = vi.fn();
renderTable(onSearchChange);

const input = screen.getByRole('textbox', { name: /search campaigns/i });
fireEvent.change(input, { target: { value: 'abc' } });
await act(async () => { vi.advanceTimersByTime(300); });
onSearchChange.mockClear();

// Simulate clear button click by changing value to empty string
fireEvent.change(input, { target: { value: '' } });

// Should have fired immediately (handleSearchChange calls onSearchChange('') directly)
expect(onSearchChange).toHaveBeenCalledWith('');
expect(onSearchChange).toHaveBeenCalledTimes(1);
});
});
13 changes: 11 additions & 2 deletions frontend/src/components/CampaignsTable.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,17 @@ export function CampaignsTable({
onSortChange?.(newSort, newOrder);
}

function handleSearchChange(value: string) {
setSearchQuery(value);
if (value === '') {
onSearchChange?.('');
}
}

useEffect(() => {
onSearchChange?.(debouncedSearchQuery);
if (debouncedSearchQuery !== '') {
onSearchChange?.(debouncedSearchQuery);
}
}, [debouncedSearchQuery, onSearchChange]);

useEffect(() => {
Expand Down Expand Up @@ -203,7 +212,7 @@ export function CampaignsTable({
<div className="board-controls">
<SearchInput
value={searchQuery}
onChange={setSearchQuery}
onChange={handleSearchChange}
disabled={isLoading}
/>
<label className="field-group" style={{ minWidth: 180 }}>
Expand Down
Loading