-
Notifications
You must be signed in to change notification settings - Fork 173
Feature: Add campaign categories filter sidebar (#602) #750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| { | ||
| "extends": ["@commitlint/config-conventional"], | ||
| "rules": { | ||
| "type-enum": [2, "always", [ | ||
| "feat", | ||
| "fix", | ||
| "docs", | ||
| "style", | ||
| "refactor", | ||
| "perf", | ||
| "test", | ||
| "build", | ||
| "ci", | ||
| "chore", | ||
| "revert" | ||
| ]], | ||
| "subject-case": [0] | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,32 @@ | ||||||||||||||||||
| name: Deploy Storybook to GitHub Pages | ||||||||||||||||||
|
|
||||||||||||||||||
| on: | ||||||||||||||||||
| push: | ||||||||||||||||||
| branches: [main] | ||||||||||||||||||
| paths: | ||||||||||||||||||
| - 'frontend/**' | ||||||||||||||||||
|
|
||||||||||||||||||
| permissions: | ||||||||||||||||||
| contents: write | ||||||||||||||||||
| pages: write | ||||||||||||||||||
| id-token: write | ||||||||||||||||||
|
|
||||||||||||||||||
| jobs: | ||||||||||||||||||
| build-and-deploy: | ||||||||||||||||||
| runs-on: ubuntu-latest | ||||||||||||||||||
| defaults: | ||||||||||||||||||
| run: | ||||||||||||||||||
| working-directory: frontend | ||||||||||||||||||
| steps: | ||||||||||||||||||
| - uses: actions/checkout@v4 | ||||||||||||||||||
|
DanbabaJr marked this conversation as resolved.
|
||||||||||||||||||
| - uses: actions/setup-node@v4 | ||||||||||||||||||
| with: | ||||||||||||||||||
| node-version: 18 | ||||||||||||||||||
| cache: npm | ||||||||||||||||||
| cache-dependency-path: frontend/package-lock.json | ||||||||||||||||||
| - run: npm ci | ||||||||||||||||||
| - run: npm run build-storybook | ||||||||||||||||||
| - uses: peaceiris/actions-gh-pages@v3 | ||||||||||||||||||
| with: | ||||||||||||||||||
| github_token: ${{ secrets.GITHUB_TOKEN }} | ||||||||||||||||||
| publish_dir: ./storybook-static | ||||||||||||||||||
|
Comment on lines
+29
to
+32
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🩺 Stability & Availability | 🟠 Major | ⚡ Quick win 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "== workflow files =="
git ls-files '.github/workflows/*' || true
echo "== target workflow excerpt =="
if [ -f .github/workflows/deploy-storybook.yml ]; then
cat -n .github/workflows/deploy-storybook.yml
else
echo "target workflow not found"
fi
echo "== search for storybook-static usage and defaults/working-directory =="
rg -n "storybook-static|defaults:\s*run:\s*working-directory|working-directory:|uses: peaceiris/actions-gh-pages|build-storybook|storybook" -S .
echo "== git status/stat =="
git status --short || true
git diff --stat || trueRepository: ritik4ever/stellar-goal-vault Length of output: 3787 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "== frontend package scripts and config files =="
cat -n frontend/package.json
echo "== storybook config files =="
git ls-files frontend | rg '(^|/)(.storybook|storybook\.config|vite\.config|package\.json)$' || true
for f in frontend/.storybook/main.ts frontend/.storybook/main.js frontend/.storybook/main.cjs frontend/.storybook/main.mjs frontend/.storybook/preview.ts frontend/.storybook/preview.js frontend/.storybook/preview.cjs frontend/.storybook/preview.mjs frontend/vite.config.ts frontend/vite.config.js frontend/package.json; do
if [ -f "$f" ]; then
echo "--- $f"
cat -n "$f"
fi
done
echo "== action usage refs =="
rg -n "peaceiris/actions-gh-pages" .github/workflows packages.json package.json 2>/dev/null || trueRepository: ritik4ever/stellar-goal-vault Length of output: 5773 🌐 Web query:
💡 Result: Yes, the GitHub Actions workflow syntax for Citations:
🌐 Web query:
💡 Result: In peaceiris/actions-gh-pages (including v3), the publish_dir option specifies the source directory within your repository that contains the static files you wish to deploy to the gh-pages branch [1][2]. The contents of this specified directory are copied to the root of the target branch (gh-pages by default) [1][3]. Key behaviors regarding publish_dir include: 1. Default Directory: If not specified, the action defaults to using a directory named public in the root of your repository [1][3]. 2. Path Resolution: The path provided to publish_dir is relative to the workspace root (GITHUB_WORKSPACE) [4][5]. 3. Repository Root Interaction: If you set publish_dir to. (the repository root), the action may inadvertently attempt to delete or modify the.git directory within the workspace, which can cause deployment failures [4]. It is generally recommended to use a dedicated subdirectory (e.g.,./dist or./public) for your build artifacts to avoid this [6]. 4. Cleanup Behavior: By default, the action removes existing files in the target branch before deploying the new contents from publish_dir [7]. You can use the keep_files option if you wish to preserve existing files in the target branch [8][7]. For complex setups where you need to deploy specific files or handle directories already present in the workspace, common practices include creating a dedicated build output directory or using a post-build step to copy all necessary assets into a single directory before calling the action [6][5]. Citations:
🌐 Web query:
💡 Result: In the peaceiris/actions-gh-pages version 4 GitHub Action, the publish_dir input specifies the source directory containing the static files you wish to deploy to GitHub Pages [1][2]. Key details regarding publish_dir include: - Function: It defines the directory from which the action will copy and deploy files [1][3]. - Default Value: The default directory is./public [1][2][4]. - Behavior: Only the contents of the specified directory are pushed to the target branch (which defaults to gh-pages) [1][3]. Example usage in a workflow file: - name: Deploy uses: peaceiris/actions-gh-pages@v4 with: github_token: ${{ secrets.GITHUB_TOKEN }} publish_dir:./public Citations:
Publish the generated Storybook directory and use a supported deploy action.
Proposed fix- - uses: peaceiris/actions-gh-pages@v3
+ - uses: peaceiris/actions-gh-pages@v4
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
- publish_dir: ./storybook-static
+ publish_dir: ./frontend/storybook-static📝 Committable suggestion
Suggested change
🧰 Tools🪛 actionlint (1.7.12)[error] 29-29: the runner of "peaceiris/actions-gh-pages@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue (action) 🤖 Prompt for AI AgentsSource: Linters/SAST tools |
||||||||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,4 +11,5 @@ contracts/.stellar/ | |
| backend/data/ | ||
| CLAUDE.md | ||
| pr.md | ||
| issue.md | ||
| issue.md | ||
| storybook-static/ | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| npx --no-install commitlint --edit $1 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| "$schema": "https://app.kilo.ai/config.json" | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,21 @@ | ||
| import type { StorybookConfig } from '@storybook/react-vite'; | ||
|
|
||
| const config: StorybookConfig = { | ||
| "stories": [ | ||
| "../src/**/*.mdx", | ||
| "../src/**/*.stories.@(js|jsx|mjs|ts|tsx)" | ||
| stories: [ | ||
| '../src/**/*.mdx', | ||
| '../src/**/*.stories.@(js|jsx|mjs|ts|tsx)', | ||
| ], | ||
| "addons": [ | ||
| "@chromatic-com/storybook", | ||
| "@storybook/addon-vitest", | ||
| "@storybook/addon-a11y", | ||
| "@storybook/addon-docs", | ||
| "@storybook/addon-mcp" | ||
| addons: [ | ||
| '@chromatic-com/storybook', | ||
| '@storybook/addon-vitest', | ||
| '@storybook/addon-a11y', | ||
| '@storybook/addon-docs', | ||
| ], | ||
| "framework": "@storybook/react-vite" | ||
| framework: '@storybook/react-vite', | ||
| outputPath: 'storybook-static', | ||
| viteFinal: (config) => { | ||
| config.base = '/stellar-goal-vault/'; | ||
| return config; | ||
| }, | ||
| }; | ||
| export default config; |
Uh oh!
There was an error while loading. Please reload this page.