Skip to content

Sourcery Starbot ⭐ refactored rlclaro/django-admin-shortcuts#1

Open
SourceryAI wants to merge 1 commit into
rlclaro:masterfrom
SourceryAI:master
Open

Sourcery Starbot ⭐ refactored rlclaro/django-admin-shortcuts#1
SourceryAI wants to merge 1 commit into
rlclaro:masterfrom
SourceryAI:master

Conversation

@SourceryAI

Copy link
Copy Markdown

Thanks for starring sourcery-ai/sourcery ✨ 🌟 ✨

Here's your pull request refactoring your most popular Python repo.

If you want Sourcery to refactor all your Python repos and incoming pull requests install our bot.

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch https://github.com/sourcery-ai-bot/django-admin-shortcuts master
git merge --ff-only FETCH_HEAD
git reset HEAD^

result = result(request)
else:
result = result()
result = result(request) if 'request' in args else result()

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function eval_func refactored with the following changes:

Comment on lines -100 to +104
for key, value in CLASS_MAPPINGS:
if key is not None and key in url:
return value
return 'config' # default icon
return next(
(
value
for key, value in CLASS_MAPPINGS
if key is not None and key in url
),
'config',
)

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function get_shortcut_class refactored with the following changes:

  • Use the built-in function next instead of a for-loop (use-next)

This removes the following comments ( why? ):

# default icon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant