Conversation
aeharbo
approved these changes
Mar 25, 2026
Collaborator
aeharbo
left a comment
There was a problem hiding this comment.
New functions and tests look good. Adding the extra blank lines for clarity on input.py is a good move.
Glad you didn't have to deal with too many re-indexing issues outside of the test functions.
HyeongHan
reviewed
Mar 25, 2026
Owner
Author
|
Thanks both. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the next PR for the Roman PSF. The main feature it adds is to allow multiprocessing during the fits of the 18 SCAs.
We already had a utility function called run_multi, which we use in a few other places as well. So most of the changes here are reorganizing the work for each SCA so there is a self-contained job to pass to each worker.
There are a few other minor cleanup items I'm also including: