Skip to content

generalize more script to new multipv format - #128

Merged
robertnurnberg merged 2 commits into
mainfrom
gen
Jul 24, 2026
Merged

generalize more script to new multipv format#128
robertnurnberg merged 2 commits into
mainfrom
gen

Conversation

@robertnurnberg

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the EPD-parsing logic in the matestats.py and diffmates.py helper scripts to support a newer “multipv” style where bm may be absent, and to skip comment lines.

Changes:

  • Update the EPD regex in both scripts to capture a 4-field FEN prefix and make bm #...; optional.
  • Ignore # comment lines in both scripts.
  • In matestats.py, adjust the “loaded” summary and average computation to use the count of positions that actually have bm values.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
matestats.py Makes bm optional and updates summary/average output; adds comment-line skipping.
diffmates.py Makes bm optional, skips comment lines, and avoids treating missing bm as “missing position”.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread matestats.py Outdated
Comment thread matestats.py

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

matestats.py:32

  • bm is an int or None, but if bm: treats 0 as falsey and would skip counting/plotting a valid bm #0; value if it ever appears. Use an explicit None check so all numeric bm values are handled consistently.
                if bm:

@robertnurnberg
robertnurnberg merged commit c64459d into main Jul 24, 2026
1 check passed
@robertnurnberg
robertnurnberg deleted the gen branch July 24, 2026 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants