generalize more script to new multipv format - #128
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the EPD-parsing logic in the matestats.py and diffmates.py helper scripts to support a newer “multipv” style where bm may be absent, and to skip comment lines.
Changes:
- Update the EPD regex in both scripts to capture a 4-field FEN prefix and make
bm #...;optional. - Ignore
#comment lines in both scripts. - In
matestats.py, adjust the “loaded” summary and average computation to use the count of positions that actually havebmvalues.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| matestats.py | Makes bm optional and updates summary/average output; adds comment-line skipping. |
| diffmates.py | Makes bm optional, skips comment lines, and avoids treating missing bm as “missing position”. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
matestats.py:32
bmis anintorNone, butif bm:treats0as falsey and would skip counting/plotting a validbm #0;value if it ever appears. Use an explicitNonecheck so all numeric bm values are handled consistently.
if bm:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.