Allow for trading of fractional shares.#295
Open
SamuelDonovan wants to merge 1 commit intorobinhood-unofficial:masterfrom
Open
Allow for trading of fractional shares.#295SamuelDonovan wants to merge 1 commit intorobinhood-unofficial:masterfrom
SamuelDonovan wants to merge 1 commit intorobinhood-unofficial:masterfrom
Conversation
Robinhood has allowed for trading of fractional shares since 2019. Any constraint set forth requiring the share quantity to be an integer is self-imposed at this point. The line `quantity = int(quantity)` within the submit_sell_order and submit_buy_order functions does nothing but limit functionality. pyrh/robinhood.py feat: * Allow for users to trade fractional shares.
Member
|
Have you tested that fractional trading works when you submit fractions? What sort of validation should be done to confirm the smallest fraction allowed |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Robinhood has allowed for trading of fractional shares since 2019. Any constraint set forth requiring the share quantity to be an integer is self-imposed at this point. The line
quantity = int(quantity)within the submit_sell_order and submit_buy_order functions does nothing but limit functionality.pyrh/robinhood.py
feat:
Checklist
"{ISSUE_NUM}.{feature|bugfix|doc|removal|misc}""
Related Issue
Description