Add URDF model with RViz visualization and namespaced publisher launch files - #116
Open
adityakamath wants to merge 4 commits into
Open
Add URDF model with RViz visualization and namespaced publisher launch files#116adityakamath wants to merge 4 commits into
adityakamath wants to merge 4 commits into
Conversation
…dd .gitignore The "cleanup" and "update launch file" commits accidentally committed Jupyter .ipynb_checkpoints directories alongside the renamed launch files. Also rplidar.launch and view_rplidar.launch were renamed to rplidar_publisher.launch and rplidar_publisher_viz.launch but README.md still referenced the old filenames.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
urdf/rplidar.urdf.xacro) with mesh files for RPLIDAR A1/A2, and updatesrviz/rplidar.rvizto display the robot modelrobot_state_publisher:launch/rplidar_publisher.launch(publishes the lidar node under annsnamespace, replacesrplidar.launch)launch/rplidar_publisher_desc.launch(publishesrobot_descriptionand TF for the lidar URDF)launch/rplidar_publisher_viz.launch(RViz visualization including the robot model, replacesview_rplidar.launch)CMakeLists.txtto install the newurdfdirectoryREADME.mdto reference the new launch file names.ipynb_checkpoints/directories and adds a.gitignoreto prevent recurrenceNotes
rplidar.launchandview_rplidar.launchwere renamed torplidar_publisher.launchandrplidar_publisher_viz.launchrespectively as part of this change; README references were updated accordinglyrplidar_publisher.launchwraps the node in a<group ns="$(arg ns)">, sorosrun rplidar_ros rplidarNodeClient(which subscribes to the global/scantopic) will not receive messages unless remapped or run without the namespace — flagging this as a known caveat for reviewersTest plan
roslaunch rplidar_ros rplidar_publisher_viz.launchon an A1/A2, confirm RViz shows both the laser scan and the lidar modelroslaunch rplidar_ros rplidar_publisher.launchand confirm the node starts and publishes scans under therplidarnamespace