Allow JoypadControlServer to run single thread#3101
Allow JoypadControlServer to run single thread#3101S-Dafarra wants to merge 5 commits intorobotology:masterfrom
Conversation
…the service interface Apparently, when the signal handler was setting the static flag "terminated" to false, it was also attempting to close immediately the terminator port, but this was receiving the termination message and some race condition seemed to occur on Windows
…w avoiding multithreading
S-Dafarra
requested review from
Nicogene,
randaz81 and
traversaro
as code owners
S-Dafarra
had a problem deploying
to
code-analysis
GitHub Actions
Failure
|
@S-Dafarra yarp already has a GUI with keybpord support to control the 2D direction of a robot: yarpmobilebasegui. |
|
See gbionics/yarp-device-keyboard-joypad#3 (comment) I was not really aware of yarpmobilebasegui. I needed a drop in replacement for the SDLJoypad with a good degree of customization on the axis and buttons order |
|
The main problem here is that |
|
I realized that in the single thread case I was not updating the variable with the last run time. Fixed with b060a6e |
|
3 participants
I developed a device that can emulate a joypad using a GUI (https://github.com/ami-iit/yarp-device-keyboard-joypad). Since on macOS the GUIs can be opened only from the main thread, I needed to allow the possibility of avoiding running the
JoypadControlServerin a single threaded mode.In order to do so, I had to implement the
IServiceinterface on bothJoypadControlServerandDeviceBundler. This PR also includes the modifications of #3100cc @randaz81 @traversaro @Nicogene