Skip to content

Turn legacy-loading-removed as error by default #21852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
proux01 wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −2
Open

Turn legacy-loading-removed as error by default #21852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test-suite/bugs/bug_20902_1.v
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ Delimit Scope trunc_scope with trunc.
Global Open Scope trunc_scope.
Global Open Scope type_scope.

Declare ML Module "ltac_plugin:coq-core.plugins.ltac".
Declare ML Module "rocq-runtime.plugins.ltac".

Declare ML Module "number_string_notation_plugin:coq-core.plugins.number_string_notation".
Declare ML Module "rocq-runtime.plugins.number_string_notation".

Global Set Default Proof Mode "Classic".

Expand Down
2 changes: 2 additions & 0 deletions vernac/mltop.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ end = struct

let warn_legacy_loading =
CWarnings.create ~name:"legacy-loading-removed" ~category:Deprecation.Version.v9_0
~default:AsError
Pp.(fun name ->
str "Legacy loading plugin method has been removed from Rocq, \
and the `:` syntax is deprecated, and its first \
Expand All @@ -140,6 +141,7 @@ end = struct

let warn_coq_core =
CWarnings.create ~name:"coq-core-plugin" ~category:Deprecation.Version.v9_0
~default:AsError
Pp.(fun () -> str "\"coq-core\" has been renamed to \"rocq-runtime\".")

end
Expand Down
Loading