Skip to content

Warning for missing "Proof" command and error on duplicate or late "Proof"#21865

Open
SkySkimmer wants to merge 2 commits intorocq-prover:masterfrom
SkySkimmer:warn-missing-proof
Open

Warning for missing "Proof" command and error on duplicate or late "Proof"#21865
SkySkimmer wants to merge 2 commits intorocq-prover:masterfrom
SkySkimmer:warn-missing-proof

Conversation

@SkySkimmer
Copy link
Copy Markdown
Contributor

@SkySkimmer SkySkimmer commented Apr 1, 2026 •
edited
Loading

The warning is also emitted if Next Obligation has no Proof even though it seems nobody says Proof after Next Obligation. This seems reasonable but could be avoided (forbidding Proof after Next Obligation) if we want to.

Overlays (backwards compatible):

@SkySkimmer SkySkimmer requested review from a team as code owners April 1, 2026 13:23
@SkySkimmer SkySkimmer added the request: full CI Use this label when you want your next push to trigger a full CI. label Apr 1, 2026
@SkySkimmer SkySkimmer requested a review from a team as a code owner April 1, 2026 13:23
@coqbot-app coqbot-app bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label Apr 1, 2026
@SkySkimmer SkySkimmer added kind: feature New user-facing feature request or implementation. kind: user messages Error messages, warnings, etc. labels Apr 1, 2026
@SkySkimmer SkySkimmer added this to the 9.3+rc1 milestone Apr 1, 2026
@ppedrot ppedrot self-assigned this Apr 1, 2026
@SkySkimmer SkySkimmer added the request: full CI Use this label when you want your next push to trigger a full CI. label Apr 1, 2026
@SkySkimmer SkySkimmer force-pushed the warn-missing-proof branch from 6ab9110 to f0310db Compare April 1, 2026 14:51
@coqbot-app coqbot-app bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label Apr 1, 2026
@SkySkimmer SkySkimmer changed the title Warning for missing "Proof" command Warning for missing "Proof" command and error on duplicate or late "Proof" Apr 1, 2026
@SkySkimmer SkySkimmer added the request: full CI Use this label when you want your next push to trigger a full CI. label Apr 1, 2026
@SkySkimmer SkySkimmer force-pushed the warn-missing-proof branch from f0310db to 09b800e Compare April 1, 2026 14:51
@coqbot-app coqbot-app bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label Apr 1, 2026
@SkySkimmer SkySkimmer added the request: full CI Use this label when you want your next push to trigger a full CI. label Apr 1, 2026
@SkySkimmer SkySkimmer force-pushed the warn-missing-proof branch from 09b800e to fa3165a Compare April 1, 2026 14:53
@coqbot-app coqbot-app bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label Apr 1, 2026
@SkySkimmer
Copy link
Copy Markdown
Contributor Author

SkySkimmer commented Apr 1, 2026 •
edited
Loading

Additional notes:

  • as Restart vs. Proof using flagging #13743 says, Restart puts the state as it was after the proof opening command (Goal Lemma etc), not after Proof. This is why I edited rocqdomain.py to insert a Proof after Restart.
  • Succeed and Fail cannot modify the state, so eg Goal True. Succeed idtac. idtac. will say the warning twice.

@SkySkimmer SkySkimmer added the request: full CI Use this label when you want your next push to trigger a full CI. label Apr 1, 2026
@SkySkimmer SkySkimmer force-pushed the warn-missing-proof branch from fa3165a to 346906d Compare April 1, 2026 17:21
@coqbot-app coqbot-app bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label Apr 1, 2026
@proux01 proux01 mentioned this pull request Apr 2, 2026
Merged
@SkySkimmer SkySkimmer added the request: full CI Use this label when you want your next push to trigger a full CI. label Apr 2, 2026
@SkySkimmer
Warning for missing "Proof" command and error on duplicate or late "P…
716f64c 
…roof"

The warning is also emitted if Next Obligation has no Proof even
though it seems nobody says Proof after Next Obligation. This seems
reasonable but could be avoided (forbidding Proof after Next
Obligation) if we want to.
@SkySkimmer SkySkimmer force-pushed the warn-missing-proof branch from 346906d to 716f64c Compare April 2, 2026 12:53
@coqbot-app coqbot-app bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label Apr 2, 2026
SkySkimmer
SkySkimmer commented Apr 2, 2026
View reviewed changes
@coqbot-app coqbot-app bot added the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Apr 2, 2026
@SkySkimmer
Copy link
Copy Markdown
Contributor Author

SkySkimmer commented Apr 2, 2026

@coqbot run full ci

@coqbot-app coqbot-app bot removed the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Apr 2, 2026
@SkySkimmer SkySkimmer added the needs: overlay This is breaking external developments we track in CI. label Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ppedrot ppedrot

Labels

kind: feature New user-facing feature request or implementation. kind: user messages Error messages, warnings, etc. needs: overlay This is breaking external developments we track in CI.

Projects

None yet

Milestone

9.3+rc1

Development

Successfully merging this pull request may close these issues.

2 participants

@SkySkimmer @ppedrot