Skip to content

TC search: log hint before hint is applied#21899

Open
Janno wants to merge 2 commits intorocq-prover:masterfrom
Janno:janno/typeclasses-debug
Open

TC search: log hint before hint is applied#21899
Janno wants to merge 2 commits intorocq-prover:masterfrom
Janno:janno/typeclasses-debug

Conversation

@Janno
Copy link
Copy Markdown
Contributor

@Janno Janno commented Apr 7, 2026

This adds a new line of the form 1.2.3: applying <hint> on <goal>. Without this, it is sometimes impossible to match debug output that results from running the hint to the hint, especially when a Hint Extern calls typeclasses eauto.

Fixes / closes #21898

  • Added / updated test-suite.
  • Added changelog.
  • Added / updated documentation.
    • Documented any new / changed user messages.
    • Updated documented syntax by running make doc_gram_rsts.
  • Opened overlay pull requests.

This makes the output much easier to digest, especially when `Hint
Extern`s produce new top-level searches.
@Janno Janno requested a review from a team as a code owner April 7, 2026 14:36
@coqbot-app coqbot-app bot added the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Apr 7, 2026
@Janno Janno force-pushed the janno/typeclasses-debug branch from d94cab7 to 893d321 Compare April 7, 2026 15:15
Comment on lines -2 to +3
Debug: 1.1: simple apply H on foo, 1 subgoal(s)
Debug: 1.2: applying simple apply H on foo
Debug: 1.1: applied simple apply H on foo, 1 subgoal(s)
Copy link
Copy Markdown

@gmalecha-at-skylabs gmalecha-at-skylabs Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how easy it would be, but it would probably make sense to only print two lines for Hint Extern. That would reduce verbosity of traces.

Also, the numbering here looks a bit off because 1.1 comes after 1.2.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how easy it would be, but it would probably make sense to only print two lines for Hint Extern. That would reduce verbosity of traces.

That is easy to do. In that case we might want to change the output to "executing" or "running" instead of "applying". "Applying" sounds like a thing that should be printed for all hints, not just Hint Extern.

Also, the numbering here looks a bit off because 1.1 comes after 1.2.

I think that's just a mistake I introduced.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the output to "running", limited it to Hint Extern, and fixed the numbering issue.

@Janno Janno force-pushed the janno/typeclasses-debug branch from 893d321 to a8bfd81 Compare April 8, 2026 08:38
@ppedrot ppedrot self-assigned this Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set Typeclasses Debug output is out of order

3 participants