Fix #21902: Incorrect path constraint in with Module construct.#21904
Open
ppedrot wants to merge 1 commit intorocq-prover:masterfrom
Open
Fix #21902: Incorrect path constraint in with Module construct.#21904ppedrot wants to merge 1 commit intorocq-prover:masterfrom
ppedrot wants to merge 1 commit intorocq-prover:masterfrom
Conversation
ppedrot
added
the
request: full CI
coqbot-app
bot
removed
the
request: full CI
yannl35133
reviewed
Apr 8, 2026
kernel/mod_typing.ml
Outdated
| | Algebraic (MENoFunctor (MEident mp0)) -> | ||
| let mpnew = rebuild_mp mp0 idl in | ||
| check_modpath_equiv env' mpnew mp; | ||
| let () = check_modpath_equiv env' mpnew new_mp in |
Contributor
There was a problem hiding this comment.
Can you use more understandable names than mpnew vs new_mp?
Member
Author
There was a problem hiding this comment.
There you go, here is a version without a confusing name (and the same comparison order as in the check for the toplevel case).
Contributor
There was a problem hiding this comment.
At least now it mirrors better what happens 32 lines above; not that I could attest that part was correct.
…ruct. This is seemingly not a soundness issue but it is still problematic enough.
ppedrot
added
the
request: full CI
coqbot-app
bot
removed
the
request: full CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is seemingly not a soundness issue but it is still problematic enough.