Be more resilient to garbage arguments passed to rocq check.#21910
Open
ppedrot wants to merge 1 commit intorocq-prover:masterfrom
Open
Be more resilient to garbage arguments passed to rocq check.#21910ppedrot wants to merge 1 commit intorocq-prover:masterfrom
ppedrot wants to merge 1 commit intorocq-prover:masterfrom
Conversation
We print a proper error rather than dying with an anomaly. Fix rocq-prover#14397: coqchk should handle the empty string gracefully.
ppedrot
added
kind: fix
coqbot-app
bot
removed
the
request: full CI
SkySkimmer
reviewed
Apr 9, 2026
|
|
||
| let try_add_path s l = match path_of_string s with | ||
| | Ok path -> path :: l | ||
| | Error () -> CErrors.user_err (str "Invalid path " ++ qstring s) |
Contributor
There was a problem hiding this comment.
why not user_err directly in path_of_string?
Member
Author
There was a problem hiding this comment.
I hesitated to put a warning rather than an error, and written that way it makes it easy to replace it locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We print a proper error rather than dying with an anomaly.
Fix #14397: coqchk should handle the empty string gracefully.