Add Oref-like composition API package#413
Open
medz wants to merge 2 commits into
Open
Conversation
Author
|
The evalContext in preact_signals isn't collected correctly as I'd expected simply by setting it. Instead, it doesn't have direct collection capabilities. Ideally, the flow is:
|
Owner
|
Thank you for the PR! Once thing I am tracking is the upstream changes with preact_signals and it makes it possible to keep the expected behavior the same as they make changes. If someone has a bug in the dart version it should be able to be recreated on the JS version. That being said, if it doesn't impact expected behavior I am happy to add it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm currently having issues with how I handle the effect flags, so it won't trigger the Widget rebuild correctly.
CC @rodydavis