Skip to content

Fix Silabs HAL: also send commands to group bindings #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
romasku merged 2 commits into from
Jul 25, 2026
Merged

Fix Silabs HAL: also send commands to group bindings #437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7d0a3a
Fix Silabs HAL: also send commands to group bindings
eakorolev Jun 6, 2026
ed34ecc
Merge branch 'main' into fix-silabs-multicast-bindings
eakorolev Jun 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/changelog_fw.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ Please describe what you are working on, under ## Upcoming
- Changing device type breaks Silabs NVM data
- Reset needed 11 presses instead of 10
- ZHA quirk silently failed to apply on relay-less devices with LED indicators (scene remotes), leaving firmware attributes unreachable from the UI
- Silabs: bindings to Zigbee groups ignored when emitting commands
- **New**
- SONOFF ZBMINIL2 version updates broken?

Expand Down
7 changes: 5 additions & 2 deletions src/silabs/hal/zigbee.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,8 +305,11 @@ hal_zigbee_status_t hal_zigbee_send_cmd_to_bindings(const hal_zigbee_cmd *cmd) {
fill_cmd(cmd);

sl_zigbee_af_set_command_endpoints(cmd->endpoint, cmd->endpoint);
sl_status_t st = sl_zigbee_af_send_command_unicast_to_bindings();
return (st == SL_STATUS_OK) ? HAL_ZIGBEE_OK : HAL_ZIGBEE_ERR_SEND_FAILED;
sl_status_t st_unicast = sl_zigbee_af_send_command_unicast_to_bindings();
sl_status_t st_multicast = sl_zigbee_af_send_command_multicast_to_bindings();

return (st_unicast == SL_STATUS_OK || st_multicast == SL_STATUS_OK)
? HAL_ZIGBEE_OK : HAL_ZIGBEE_ERR_SEND_FAILED;
}

hal_zigbee_status_t
Expand Down
Loading