Conversation
…oss various components
…FilterDrawer and Scan views
…lers for missing entries
…ng missing entries
…latform indications in UI
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
Contributor
Test Results92 tests 92 ✅ 29s ⏱️ Results for commit 81f9a10. ♻️ This comment has been updated with latest results. |
gantoine
requested changes
Jun 12, 2025
gantoine
left a comment
gantoine
left a comment
Member
There was a problem hiding this comment.
thanks for keeping the implementation clean 🫡
…lated logic for better tracking of missing files
…improved user interface
gantoine
approved these changes
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the scanner behaviour when any entity (rom, platform or firmware) is missing from the filesystem. Now instead of purging it from the database, will be marked as
missingavoiding user data loss. If the file is restored (same path, same filename) and a scan is performed, will be unmarked asmissingagain.Checklist
Screenshots
Closes #1784, #1976