Skip to content

fix(v2): clear gallery selection after deleting ROMs #3828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gantoine merged 6 commits into from
Jul 19, 2026
Merged

fix(v2): clear gallery selection after deleting ROMs #3828

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
da482e3
fix(v2): clear gallery selection after deleting ROMs
gantoine Jul 19, 2026
2591051
fix(v2): keep failed ROMs selected on partial delete
gantoine Jul 19, 2026
3ace17a
fix(v2): snapshot delete-dialog state before awaiting
gantoine Jul 19, 2026
02f4897
refactor: drop failed_items from BulkOperationResponse
gantoine Jul 19, 2026
556fa8f
Merge branch 'master' into fix/v2-clear-selection-after-delete
gantoine Jul 19, 2026
5c6fc37
cleanup
gantoine Jul 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions frontend/src/v2/components/Dialogs/DeleteRomDialog.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import storeRoms, { type SimpleRom } from "@/stores/roms";
import type { Events } from "@/types/emitter";
import { useSnackbar } from "@/v2/composables/useSnackbar";
import storeGalleryRoms from "@/v2/stores/galleryRoms";
import storeGallerySelection from "@/v2/stores/gallerySelection";

defineOptions({ inheritAttrs: false });

Expand All @@ -24,6 +25,7 @@ const route = useRoute();
const show = ref(false);
const romsStore = storeRoms();
const galleryRomsStore = storeGalleryRoms();
const gallerySelectionStore = storeGallerySelection();
const roms = ref<SimpleRom[]>([]);
const romsToDeleteFromFs = ref<number[]>([]);
const excludeOnDelete = ref(false);
Expand Down Expand Up @@ -101,6 +103,11 @@ async function deleteRoms() {
}
}
romsStore.resetSelection();
// Drop the deleted ROMs from the v2 gallery selection too — otherwise
// the SelectionBar stays open pointing at rows that no longer exist,
// and re-running an action 404s. removeIds only touches the deleted
// subset, so a partial delete keeps the rest of the selection intact.
gallerySelectionStore.removeIds(roms.value.map((rom) => rom.id));
Comment thread
gantoine marked this conversation as resolved.
Outdated
Comment thread
gantoine marked this conversation as resolved.
Outdated
romsStore.remove(roms.value);
galleryRomsStore.remove(roms.value);
romsStore.setRecentRoms(
Expand Down
Loading