Fix wrong error wording for flag-only providers in setup wizard#3841
Merged
Conversation
The setup wizard's metadata step showed "API key invalid" for any
enabled provider that failed its heartbeat probe, including flag-only
providers like PlayMatch and Hasheous that have no API key. This
contradicted the Settings > Metadata sources view, which already adapts
its wording per provider.
Mirror that behavior: add a `requiresKey` flag to each source and use
connection-oriented wording for flag-only providers ("Unreachable" on a
failed probe, "Provider disabled" when off) instead of key-oriented
wording. Reuses existing locale keys, so no new translations are needed.
Fixes #3795
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Greptile SummaryThis PR gives flag-only metadata providers accurate status wording in the setup wizard. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "Fix wrong error wording for flag-only pr..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Explain the changes or enhancements you are proposing with this pull request.
The setup wizard's metadata step (step 3) showed "API key invalid" for any enabled provider that failed its heartbeat probe, including flag-only providers like PlayMatch and Hasheous that have no API key. This contradicted the Settings → Metadata sources view, which already adapts its status wording per provider (key-based vs flag-only).
This PR mirrors that behavior in
SetupStepMetadata.vue:requiresKeyflag to each source (matchingMetadataSources.vue).Reuses existing locale keys (
metadata-status-unreachable,metadata-status-disabled), so no new translations are needed. This addresses the messaging inconsistency reported; the underlying PlayMatch availability problem is tracked separately in #3764.Checklist
Please check all that apply.
Screenshots (if applicable)
Fixes #3795
🤖 Generated with Claude Code