Skip to content

Fix wrong error wording for flag-only providers in setup wizard#3841

Merged
gantoine merged 2 commits into
masterfrom
fix/playmatch-wizard-error-message
Jul 20, 2026
Merged

Fix wrong error wording for flag-only providers in setup wizard#3841
gantoine merged 2 commits into
masterfrom
fix/playmatch-wizard-error-message

Conversation

@gantoine

Copy link
Copy Markdown
Member

Description
Explain the changes or enhancements you are proposing with this pull request.

The setup wizard's metadata step (step 3) showed "API key invalid" for any enabled provider that failed its heartbeat probe, including flag-only providers like PlayMatch and Hasheous that have no API key. This contradicted the Settings → Metadata sources view, which already adapts its status wording per provider (key-based vs flag-only).

This PR mirrors that behavior in SetupStepMetadata.vue:

  • Adds a requiresKey flag to each source (matching MetadataSources.vue).
  • Flag-only providers (LaunchBox, Flashpoint, HowLongToBeat, Hasheous, PlayMatch) now use connection-oriented wording:
    • Failed probe → "Unreachable" (instead of "API key invalid")
    • Disabled → "Provider disabled" with a plug-off icon (instead of "API key missing")
  • Key-based providers are unchanged.

Reuses existing locale keys (metadata-status-unreachable, metadata-status-disabled), so no new translations are needed. This addresses the messaging inconsistency reported; the underlying PlayMatch availability problem is tracked separately in #3764.

AI assistance: this change was written with the help of Claude Code (investigation, implementation, and verification). All changes were reviewed by the author.

Checklist
Please check all that apply.

  • I've tested the changes locally
  • I've updated relevant comments
  • I've assigned reviewers for this PR
  • I've added unit tests that cover the changes

Screenshots (if applicable)

Fixes #3795

🤖 Generated with Claude Code

The setup wizard's metadata step showed "API key invalid" for any
enabled provider that failed its heartbeat probe, including flag-only
providers like PlayMatch and Hasheous that have no API key. This
contradicted the Settings > Metadata sources view, which already adapts
its wording per provider.

Mirror that behavior: add a `requiresKey` flag to each source and use
connection-oriented wording for flag-only providers ("Unreachable" on a
failed probe, "Provider disabled" when off) instead of key-oriented
wording. Reuses existing locale keys, so no new translations are needed.

Fixes #3795

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 19, 2026 23:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@greptile-apps

greptile-apps Bot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR gives flag-only metadata providers accurate status wording in the setup wizard. The main changes are:

  • Classifies each provider as key-based or flag-only.
  • Shows “Provider disabled” for disabled flag-only providers.
  • Shows “Unreachable” when a flag-only provider fails its probe.

Confidence Score: 5/5

This looks safe to merge.

  • Every provider initializes the new required field.
  • Provider classifications match the existing Metadata Sources settings view.
  • The referenced status translations already exist.
  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
frontend/src/v2/components/Auth/SetupStepMetadata.vue Adds provider classification and selects disabled or failed-probe labels based on whether an API key is required.

Reviews (1): Last reviewed commit: "Fix wrong error wording for flag-only pr..." | Re-trigger Greptile

@gantoine
gantoine merged commit 9f9f502 into master Jul 20, 2026
10 checks passed
@gantoine
gantoine deleted the fix/playmatch-wizard-error-message branch July 20, 2026 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Wrong error for PlayMatch in setup wizard

2 participants