Skip to content

fix(v2): ignore phantom/non-standard gamepads in nav polling #3852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gantoine merged 3 commits into from
Jul 20, 2026
+11 −2
Merged

fix(v2): ignore phantom/non-standard gamepads in nav polling #3852

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bee0045
fix(v2): ignore phantom/non-standard gamepads in nav polling
gantoine Jul 20, 2026
2c4ce5f
fix(v2): gate phantom-pad guard on connected only, not mapping
gantoine Jul 20, 2026
f223da4
cleanup
gantoine Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions frontend/src/v2/composables/useGamepad/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,16 @@ const BUTTON_MAP: Record<number, Binding | undefined> = {
15: { key: "ArrowRight", code: "ArrowRight" },
};

// Guards the polling loop against phantom / non-standard pads. All button
// and axis reads use W3C standard-mapping indices, so a pad that is
// disconnected or reports a non-standard mapping cannot be interpreted
// safely. Firefox surfaces such devices and their analog drift would
// otherwise trigger index-based actions (e.g. LB/RB section cycling) on
// their own. See issue #3851.
function isUsablePad(pad: Gamepad | null): pad is Gamepad {
return pad !== null && pad.connected && pad.mapping === "standard";
Comment thread
gantoine marked this conversation as resolved.
Outdated
}

function dispatchKey(binding: Binding) {
const target =
(document.activeElement as HTMLElement | null) ?? document.body;
Expand Down Expand Up @@ -229,7 +239,7 @@ export function useGamepad() {
// or first button press takes over.
function detectPadPresence() {
const list = navigator.getGamepads?.() ?? [];
const hasPad = Array.from(list).some((p) => p !== null);
const hasPad = Array.from(list).some((p) => isUsablePad(p));
if (hasPad && !everSawPad) {
everSawPad = true;
setModality("pad");
Expand Down Expand Up @@ -257,7 +267,12 @@ export function useGamepad() {
const actionsDisabled = ACTIONS_DISABLED_PATHS.has(route.path);

for (const pad of pads) {
if (!pad) continue;
// Only act on connected, standard-mapping pads: every button/axis
// read below is by W3C standard index, so a phantom or non-standard
// pad (Firefox keeps disconnected entries around and reports
// uncalibrated analog controls) would map drifting values onto LB/RB
// and cycle AppNav sections with no user input. See issue #3851.
if (!isUsablePad(pad)) continue;
const key = `${pad.index}:${pad.id}`;
const st = (states[key] ||= {
buttons: {},
Expand Down
Loading