#482 uncovered that we were bundling the entire TypeScript compiler into Blade, which shouldn't be happening.
The PR defined the dependency as external, which means that projects now have to define it themselves in order to make use of the blade types command.
However there is still one problem: If typescript is not present, all blade commands crash at bootup time. Instead, I would say that only the codegen-related commands should require the dependency, right?
The other option is adding typescript as a dependency to Blade, which seems overkill considering that many people install typescript on their own project due to defining a tsconfig.json.
Once that's done, the extra dependency added in #486 and https://github.com/ronin-co/front/pull/130 should be removed again.
#482 uncovered that we were bundling the entire TypeScript compiler into Blade, which shouldn't be happening.
The PR defined the dependency as external, which means that projects now have to define it themselves in order to make use of the
blade typescommand.However there is still one problem: If
typescriptis not present, allbladecommands crash at bootup time. Instead, I would say that only the codegen-related commands should require the dependency, right?The other option is adding
typescriptas a dependency to Blade, which seems overkill considering that many people installtypescripton their own project due to defining atsconfig.json.Once that's done, the extra dependency added in #486 and https://github.com/ronin-co/front/pull/130 should be removed again.