make entrez_search() use POST (and some minor typo fixes)#164
Open
billdenney wants to merge 1 commit intoropensci:masterfrom
Open
make entrez_search() use POST (and some minor typo fixes)#164billdenney wants to merge 1 commit intoropensci:masterfrom
billdenney wants to merge 1 commit intoropensci:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #163.
It causes
entrez_search()to use HTTP POST instead of GET for all calls. This doesn't appear to have a downside, and all tests passed. I did not simply force all requests to go through POST since I assumed that there was a reason for only testing theidsargument and using GET for some calls.