Let bcpc_query also find derivatives - #440
Merged
Merged
Conversation
Contributor
|
Thanks @jranke for opening this PR, I'll rebase and then we'll see if the checks pass. |
Contributor
|
On second thought, I don't think I can rebase your branch, can you please rebase and force push? |
Contributor
Author
|
Hi Tamás, I pulled the master branch and merged it into the branch used for the PR, and pushed, so this can be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #439
Brief description of the PR
PR task list:
devtools::document()Regarding the last item, I did check if the package passed, but I got the same four test failures for
test_chemblthat occur in CI on the master branch.