Skip to content

Add string array to lexical casts#2333

Merged
christophfroehlich merged 2 commits into
ros-controls:masterfrom
jordan-palacios:feat/add_string_array_to_lexical_casts
Jun 23, 2025
Merged

Add string array to lexical casts#2333
christophfroehlich merged 2 commits into
ros-controls:masterfrom
jordan-palacios:feat/add_string_array_to_lexical_casts

Conversation

@jordan-palacios

Copy link
Copy Markdown
Member

This PR aims to increase the amount of supported parsed types in lexical casts by adding a string array parsing.

Since I was at it, I added tests for all the lexical casts functions; old and new.

@codecov

codecov Bot commented Jun 20, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.94%. Comparing base (f97a2cb) to head (c532fd9).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
hardware_interface/src/lexical_casts.cpp 95.45% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2333      +/-   ##
==========================================
- Coverage   88.97%   88.94%   -0.04%     
==========================================
  Files         143      144       +1     
  Lines       16608    16634      +26     
  Branches     1429     1436       +7     
==========================================
+ Hits        14777    14795      +18     
- Misses       1275     1279       +4     
- Partials      556      560       +4     
Flag Coverage Δ
unittests 88.94% <96.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
hardware_interface/test/test_lexical_casts.cpp 100.00% <100.00%> (ø)
hardware_interface/src/lexical_casts.cpp 91.42% <95.45%> (+6.81%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@saikishor saikishor added the backport-jazzy Triggers PR backport to ROS 2 jazzy. label Jun 20, 2025
@jordan-palacios jordan-palacios force-pushed the feat/add_string_array_to_lexical_casts branch from 734dd62 to c532fd9 Compare June 22, 2025 09:28

@christophfroehlich christophfroehlich left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@christophfroehlich

Copy link
Copy Markdown
Member

Failing RHEL tests are not related to this PR, but pal-robotics/pal_statistics#16

@christophfroehlich christophfroehlich merged commit 4d3362d into ros-controls:master Jun 23, 2025
21 of 26 checks passed
mergify Bot pushed a commit that referenced this pull request Jun 23, 2025
saikishor pushed a commit that referenced this pull request Jun 23, 2025
(cherry picked from commit 4d3362d)

Co-authored-by: Jordan Palacios <jordan.palacios@pal-robotics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-jazzy Triggers PR backport to ROS 2 jazzy.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants