Add string array to lexical casts#2333
Merged
christophfroehlich merged 2 commits intoJun 23, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2333 +/- ##
==========================================
- Coverage 88.97% 88.94% -0.04%
==========================================
Files 143 144 +1
Lines 16608 16634 +26
Branches 1429 1436 +7
==========================================
+ Hits 14777 14795 +18
- Misses 1275 1279 +4
- Partials 556 560 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
734dd62 to
c532fd9
Compare
saikishor
approved these changes
Jun 23, 2025
Member
|
Failing RHEL tests are not related to this PR, but pal-robotics/pal_statistics#16 |
4d3362d
into
ros-controls:master
21 of 26 checks passed
mergify Bot
pushed a commit
that referenced
this pull request
Jun 23, 2025
(cherry picked from commit 4d3362d)
saikishor
pushed a commit
that referenced
this pull request
Jun 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to increase the amount of supported parsed types in lexical casts by adding a string array parsing.
Since I was at it, I added tests for all the lexical casts functions; old and new.