Add deprecations to old methods not using Structs #2344
Merged
bmagyar merged 8 commits intoJul 1, 2025
Merged
Conversation
soham2560
suggested changes
Jun 27, 2025
Co-authored-by: Soham Patil <sohampatil45939@gmail.com>
Member
Author
I'll open another PR for the cleanup. The scope of this PR is only upto deprecations |
soham2560
reviewed
Jun 27, 2025
soham2560
suggested changes
Jun 27, 2025
soham2560
left a comment
Contributor
There was a problem hiding this comment.
just that one file remaining, rest LGTM
bmagyar
reviewed
Jun 30, 2025
saikishor
commented
Jun 30, 2025
bmagyar
approved these changes
Jul 1, 2025
mergify Bot
pushed a commit
that referenced
this pull request
Jul 1, 2025
(cherry picked from commit abbf8d6) # Conflicts: # hardware_interface/include/hardware_interface/actuator_interface.hpp # hardware_interface/include/hardware_interface/resource_manager.hpp # hardware_interface/include/hardware_interface/sensor_interface.hpp # hardware_interface/include/hardware_interface/system_interface.hpp
bmagyar
pushed a commit
that referenced
this pull request
Jul 21, 2025
This was referenced Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds deprecations to the old methods