Skip to content

Add deprecations to old methods not using Structs #2344

Merged
bmagyar merged 8 commits into
ros-controls:masterfrom
pal-robotics-forks:add/deprecations/pimpl/approach
Jul 1, 2025
Merged

Add deprecations to old methods not using Structs #2344
bmagyar merged 8 commits into
ros-controls:masterfrom
pal-robotics-forks:add/deprecations/pimpl/approach

Conversation

@saikishor

Copy link
Copy Markdown
Member

This PR adds deprecations to the old methods

@codecov

codecov Bot commented Jun 27, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 90.25974% with 15 lines in your changes missing coverage. Please review.

Project coverage is 88.85%. Comparing base (2e82c40) to head (b9765fe).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...rface_testing/test/test_components/test_sensor.cpp 25.00% 2 Missing and 1 partial ⚠️
...rface_testing/test/test_components/test_system.cpp 25.00% 2 Missing and 1 partial ⚠️
...hardware_components/test_single_joint_actuator.cpp 0.00% 2 Missing ⚠️
...e_interface/src/mock_components/generic_system.cpp 75.00% 0 Missing and 1 partial ⚠️
...t_hardware_components/test_force_torque_sensor.cpp 50.00% 0 Missing and 1 partial ⚠️
.../test/test_hardware_components/test_imu_sensor.cpp 50.00% 0 Missing and 1 partial ⚠️
...ware_components/test_system_with_command_modes.cpp 50.00% 0 Missing and 1 partial ⚠️
...test_hardware_components/test_two_joint_system.cpp 50.00% 0 Missing and 1 partial ⚠️
...ace_testing/test/test_components/test_actuator.cpp 75.00% 0 Missing and 1 partial ⚠️
..._components/test_actuator_exclusive_interfaces.cpp 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2344      +/-   ##
==========================================
- Coverage   88.99%   88.85%   -0.14%     
==========================================
  Files         148      148              
  Lines       16805    16891      +86     
  Branches     1438     1438              
==========================================
+ Hits        14955    15009      +54     
- Misses       1287     1317      +30     
- Partials      563      565       +2     
Flag Coverage Δ
unittests 88.85% <90.25%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
..._interface/include/hardware_interface/actuator.hpp 100.00% <ø> (ø)
.../include/hardware_interface/actuator_interface.hpp 91.30% <100.00%> (ø)
...re_interface/include/hardware_interface/sensor.hpp 100.00% <ø> (ø)
...ce/include/hardware_interface/sensor_interface.hpp 85.98% <100.00%> (ø)
...re_interface/include/hardware_interface/system.hpp 100.00% <ø> (ø)
...ce/include/hardware_interface/system_interface.hpp 84.80% <100.00%> (ø)
...terface/include/mock_components/generic_system.hpp 100.00% <ø> (ø)
hardware_interface/src/actuator.cpp 76.53% <ø> (-4.09%) ⬇️
hardware_interface/src/sensor.cpp 72.43% <ø> (-5.13%) ⬇️
hardware_interface/src/system.cpp 76.92% <ø> (-4.11%) ⬇️
... and 13 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@saikishor saikishor marked this pull request as ready for review June 27, 2025 14:38

@soham2560 soham2560 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes. on a side note, should the template function for initialize_hardware in RM also have deprecation warning

Comment thread hardware_interface/include/hardware_interface/actuator.hpp Outdated
Comment thread hardware_interface/include/hardware_interface/actuator.hpp Outdated
Comment thread hardware_interface/include/hardware_interface/sensor.hpp Outdated
Comment thread hardware_interface/include/hardware_interface/sensor.hpp Outdated
Comment thread hardware_interface/include/hardware_interface/system.hpp Outdated
Comment thread hardware_interface/include/hardware_interface/system.hpp Outdated
Comment thread hardware_interface/include/mock_components/generic_system.hpp Outdated
Comment thread hardware_interface/test/test_component_interfaces.cpp Outdated
Co-authored-by: Soham Patil <sohampatil45939@gmail.com>
@saikishor

Copy link
Copy Markdown
Member Author

minor changes. on a side note, should the template function for initialize_hardware in RM also have deprecation warning

I'll open another PR for the cleanup. The scope of this PR is only upto deprecations

@saikishor saikishor requested a review from soham2560 June 27, 2025 15:57
Comment thread hardware_interface/test/test_component_interfaces.cpp Outdated

@soham2560 soham2560 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just that one file remaining, rest LGTM

@saikishor saikishor requested a review from soham2560 June 28, 2025 07:36

@soham2560 soham2560 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread hardware_interface/include/mock_components/generic_system.hpp
Comment thread hardware_interface/include/hardware_interface/sensor_interface.hpp
Comment thread hardware_interface/include/mock_components/generic_system.hpp
@bmagyar bmagyar merged commit abbf8d6 into ros-controls:master Jul 1, 2025
17 of 26 checks passed
@bmagyar bmagyar deleted the add/deprecations/pimpl/approach branch July 1, 2025 12:16
@saikishor saikishor added the backport-jazzy Triggers PR backport to ROS 2 jazzy. label Jul 1, 2025
mergify Bot pushed a commit that referenced this pull request Jul 1, 2025
(cherry picked from commit abbf8d6)

# Conflicts:
#	hardware_interface/include/hardware_interface/actuator_interface.hpp
#	hardware_interface/include/hardware_interface/resource_manager.hpp
#	hardware_interface/include/hardware_interface/sensor_interface.hpp
#	hardware_interface/include/hardware_interface/system_interface.hpp
@fmauch fmauch mentioned this pull request Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-jazzy Triggers PR backport to ROS 2 jazzy.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants