Cleanup old internal API#2346
Merged
bmagyar merged 2 commits intoJul 1, 2025
Merged
Conversation
github-actions
Bot
requested review from
ARK3r,
Maverobot,
anfemosa,
aprotyas,
bmagyar,
christophfroehlich,
destogl,
harderthan,
homalozoa,
mcbed,
peterdavidfagan and
rosterloh
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2346 +/- ##
=======================================
Coverage 88.99% 88.99%
=======================================
Files 148 148
Lines 16805 16806 +1
Branches 1438 1438
=======================================
+ Hits 14955 14956 +1
Misses 1287 1287
Partials 563 563
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
soham2560
suggested changes
Jun 28, 2025
soham2560
approved these changes
Jun 29, 2025
mergify Bot
pushed a commit
that referenced
this pull request
Jul 1, 2025
(cherry picked from commit cd7e522) # Conflicts: # controller_manager/src/controller_manager.cpp # hardware_interface/src/resource_manager.cpp
saikishor
added a commit
that referenced
this pull request
Jul 21, 2025
saikishor
added a commit
that referenced
this pull request
Jul 21, 2025
bmagyar
pushed a commit
that referenced
this pull request
Jul 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans up old internal API that is unused after #2323 :)